Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: client/capture_context_mac_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/simple_string_dictionary_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/capture_context_mac_test.cc
diff --git a/client/capture_context_mac_test.cc b/client/capture_context_mac_test.cc
index 53d08e264b482d761cdd1b925aafde0cd3f3f6cf..3dc0ba8dabc1e80e21c4c238cf27396a822e58c7 100644
--- a/client/capture_context_mac_test.cc
+++ b/client/capture_context_mac_test.cc
@@ -22,10 +22,10 @@
#include "build/build_config.h"
#include "gtest/gtest.h"
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-
// If the context structure has fields that tell whether it’s valid, such as
// magic numbers or size fields, sanity-checks those fields for validity with
// fatal gtest assertions. For other fields, where it’s possible to reason about
@@ -152,3 +152,5 @@ TEST(CaptureContextMac, CaptureContext) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « no previous file | client/simple_string_dictionary_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698