util/mac/launchd_test.mm - Issue 635883002: Don’t use using directives (“using namespace”) in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mac/launchd_test.mm

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/mac/launchd_test.mm

diff --git a/util/mac/launchd_test.mm b/util/mac/launchd_test.mm

index b4c8f34af296ca12cffe5216d5d52bfa1562f6c0..03953cdfc3b41e6ffde98306605c45e038a5c802 100644

--- a/util/mac/launchd_test.mm

+++ b/util/mac/launchd_test.mm

@@ -26,10 +26,10 @@

#include "gtest/gtest.h"

#include "util/stdlib/objc.h"

+namespace crashpad {

+namespace test {

namespace {

-using namespace crashpad;

TEST(Launchd, CFPropertyToLaunchData_Integer) {

@autoreleasepool {

base::mac::ScopedLaunchData launch_data;

@@ -301,3 +301,5 @@ TEST(Launchd, CFPropertyToLaunchData_RealWorldJobDictionary) {

}

} // namespace

+} // namespace test

+} // namespace crashpad

« no previous file with comments | « util/mac/checked_mach_address_range_test.cc ('k') | util/mac/mac_util_test.mm » ('j') | no next file with comments »