Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: util/stdlib/string_number_conversion_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/posix/symbolic_constants_posix_test.cc ('k') | util/stdlib/strlcpy_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/stdlib/string_number_conversion.h" 15 #include "util/stdlib/string_number_conversion.h"
16 16
17 #include "base/basictypes.h" 17 #include "base/basictypes.h"
18 #include "gtest/gtest.h" 18 #include "gtest/gtest.h"
19 19
20 #include <limits> 20 #include <limits>
21 21
22 namespace crashpad {
23 namespace test {
22 namespace { 24 namespace {
23 25
24 using namespace crashpad;
25
26 TEST(StringNumberConversion, StringToInt) { 26 TEST(StringNumberConversion, StringToInt) {
27 const struct { 27 const struct {
28 const char* string; 28 const char* string;
29 bool valid; 29 bool valid;
30 int value; 30 int value;
31 } kTestData[] = { 31 } kTestData[] = {
32 {"", false, 0}, 32 {"", false, 0},
33 {"0", true, 0}, 33 {"0", true, 0},
34 {"1", true, 1}, 34 {"1", true, 1},
35 {"2147483647", true, std::numeric_limits<int>::max()}, 35 {"2147483647", true, std::numeric_limits<int>::max()},
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 base::StringPiece input_string(input, arraysize(input) - 1); 209 base::StringPiece input_string(input, arraysize(input) - 1);
210 unsigned int output; 210 unsigned int output;
211 EXPECT_FALSE(StringToNumber(input_string, &output)); 211 EXPECT_FALSE(StringToNumber(input_string, &output));
212 212
213 // Ensure that a NUL is not required at the end of the string. 213 // Ensure that a NUL is not required at the end of the string.
214 EXPECT_TRUE(StringToNumber(base::StringPiece("66", 1), &output)); 214 EXPECT_TRUE(StringToNumber(base::StringPiece("66", 1), &output));
215 EXPECT_EQ(6u, output); 215 EXPECT_EQ(6u, output);
216 } 216 }
217 217
218 } // namespace 218 } // namespace
219 } // namespace test
220 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/posix/symbolic_constants_posix_test.cc ('k') | util/stdlib/strlcpy_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698