Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: util/posix/symbolic_constants_posix_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/posix/process_util_test.cc ('k') | util/stdlib/string_number_conversion_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/posix/symbolic_constants_posix.h" 15 #include "util/posix/symbolic_constants_posix.h"
16 16
17 #include <sys/signal.h> 17 #include <sys/signal.h>
18 18
19 #include "base/basictypes.h" 19 #include "base/basictypes.h"
20 #include "base/strings/string_piece.h" 20 #include "base/strings/string_piece.h"
21 #include "base/strings/stringprintf.h" 21 #include "base/strings/stringprintf.h"
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 23
24 #define NUL_TEST_DATA(string) { string, arraysize(string) - 1 } 24 #define NUL_TEST_DATA(string) { string, arraysize(string) - 1 }
25 25
26 namespace crashpad {
27 namespace test {
26 namespace { 28 namespace {
27 29
28 using namespace crashpad;
29
30 const struct { 30 const struct {
31 int signal; 31 int signal;
32 const char* full_name; 32 const char* full_name;
33 const char* short_name; 33 const char* short_name;
34 } kSignalTestData[] = { 34 } kSignalTestData[] = {
35 {SIGABRT, "SIGABRT", "ABRT"}, 35 {SIGABRT, "SIGABRT", "ABRT"},
36 {SIGALRM, "SIGALRM", "ALRM"}, 36 {SIGALRM, "SIGALRM", "ALRM"},
37 {SIGBUS, "SIGBUS", "BUS"}, 37 {SIGBUS, "SIGBUS", "BUS"},
38 {SIGCHLD, "SIGCHLD", "CHLD"}, 38 {SIGCHLD, "SIGCHLD", "CHLD"},
39 {SIGCONT, "SIGCONT", "CONT"}, 39 {SIGCONT, "SIGCONT", "CONT"},
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 base::StringPiece("SIGBUST", 6), kAllowFullName, true, SIGBUS); 245 base::StringPiece("SIGBUST", 6), kAllowFullName, true, SIGBUS);
246 } 246 }
247 { 247 {
248 SCOPED_TRACE("trailing_NUL_short"); 248 SCOPED_TRACE("trailing_NUL_short");
249 TestStringToSignal( 249 TestStringToSignal(
250 base::StringPiece("BUST", 3), kAllowShortName, true, SIGBUS); 250 base::StringPiece("BUST", 3), kAllowShortName, true, SIGBUS);
251 } 251 }
252 } 252 }
253 253
254 } // namespace 254 } // namespace
255 } // namespace test
256 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/posix/process_util_test.cc ('k') | util/stdlib/string_number_conversion_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698