Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: util/mac/mach_o_image_reader_test.cc

Issue 635883002: Don’t use using directives (“using namespace”) in tests (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mac/mac_util_test.mm ('k') | util/mac/mach_o_image_segment_reader_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/mach_o_image_reader_test.cc
diff --git a/util/mac/mach_o_image_reader_test.cc b/util/mac/mach_o_image_reader_test.cc
index 2991cc5f0996e061e0d6d277ccbd083028e47aa7..f174a4ea03da12b18f099f8bd4bf50c60a6e5603 100644
--- a/util/mac/mach_o_image_reader_test.cc
+++ b/util/mac/mach_o_image_reader_test.cc
@@ -36,10 +36,10 @@
// This file is responsible for testing MachOImageReader,
// MachOImageSegmentReader, and MachOImageSymbolTableReader.
+namespace crashpad {
+namespace test {
namespace {
-using namespace crashpad;
-
// Native types and constants, in cases where the 32-bit and 64-bit versions
// are different.
#if defined(ARCH_CPU_64_BITS)
@@ -659,3 +659,5 @@ TEST(MachOImageReader, Self_DyldImages) {
}
} // namespace
+} // namespace test
+} // namespace crashpad
« no previous file with comments | « util/mac/mac_util_test.mm ('k') | util/mac/mach_o_image_segment_reader_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698