Chromium Code Reviews
Help | Chromium Project | Sign in
(78)

Issue 143323014: *** DO NOT LAND *** Attempt to understand Regions complexity

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by eseidel
Modified:
1 year, 5 months ago
Reviewers:
Visibility:
Public.

Description

*** DO NOT LAND *** Attempt to understand Regions complexity *** DO NOT LAND *** This patch attempts to understand exactly how much code we have in Blink to support the CSS Regions feature and where that code reaches. This is definitely an incomplete patch as it does not include any of the LayerFragment complexity which I did not attempt to untangle. This patch builds and passes many layout tests (although obviously not the Regions or tests). Hopefully this is a useful tool for allowing all of us to visualize exactly the complexity cost of CSS Regions in the Blink codebase. Git tells me that this diff removes 10,000 lines. For context, Ohloh tells us that there are only 350,000 lines of C++ in all of Blink. http://www.ohloh.net/p/chromium-blink/analyses/latest/languages_summary

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -10167 lines) Patch
M Source/bindings/v8/custom/V8CSSRuleCustom.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 9 chunks +0 lines, -29 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 5 chunks +0 lines, -26 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 8 chunks +0 lines, -62 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/core/css/CSSProperties.in View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/css/CSSRegionRule.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/css/CSSRegionRule.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M Source/core/css/CSSRule.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSRule.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSRule.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSTokenizer-in.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M Source/core/css/RuleSet.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 3 chunks +0 lines, -29 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleRule.h View 4 chunks +0 lines, -21 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 5 chunks +0 lines, -23 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 2 chunks +1 line, -5 lines 0 comments Download
D Source/core/css/WebKitCSSRegionRule.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 7 chunks +0 lines, -131 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 4 chunks +1 line, -19 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 8 chunks +2 lines, -33 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D Source/core/dom/DOMNamedFlowCollection.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/dom/DOMNamedFlowCollection.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M Source/core/dom/Document.h View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +0 lines, -25 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 5 chunks +0 lines, -14 lines 0 comments Download
M Source/core/dom/Element.cpp View 5 chunks +0 lines, -94 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 3 chunks +0 lines, -11 lines 0 comments Download
M Source/core/dom/ElementRareData.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/core/dom/NamedFlow.h View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/core/dom/NamedFlow.cpp View 1 chunk +0 lines, -249 lines 0 comments Download
D Source/core/dom/NamedFlowCollection.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/dom/NamedFlowCollection.cpp View 1 chunk +0 lines, -134 lines 0 comments Download
M Source/core/dom/Node.h View 3 chunks +1 line, -7 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 7 chunks +1 line, -89 lines 0 comments Download
D Source/core/dom/WebKitNamedFlow.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/dom/WebKitNamedFlowCollection.idl View 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/events/EventTarget.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 7 chunks +0 lines, -19 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 9 chunks +0 lines, -264 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 5 chunks +4 lines, -8 lines 0 comments Download
D Source/core/rendering/FlowThreadController.h View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/core/rendering/FlowThreadController.cpp View 1 chunk +0 lines, -248 lines 0 comments Download
M Source/core/rendering/HitTestLocation.h View 4 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/HitTestLocation.cpp View 7 chunks +2 lines, -10 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/LayerPaintingInfo.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/rendering/LayoutState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/LayoutState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/PaintInfo.h View 3 chunks +1 line, -4 lines 0 comments Download
D Source/core/rendering/RegionOversetState.h View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 7 chunks +5 lines, -44 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 28 chunks +27 lines, -249 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 8 chunks +5 lines, -43 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 19 chunks +13 lines, -122 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 13 chunks +7 lines, -130 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 8 chunks +9 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 43 chunks +46 lines, -287 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 7 chunks +6 lines, -28 lines 0 comments Download
D Source/core/rendering/RenderBoxRegionInfo.h View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 5 chunks +3 lines, -14 lines 0 comments Download
D Source/core/rendering/RenderFlowThread.h View 1 chunk +0 lines, -323 lines 0 comments Download
D Source/core/rendering/RenderFlowThread.cpp View 1 chunk +0 lines, -1184 lines 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 4 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 5 chunks +2 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 29 chunks +25 lines, -156 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.cpp View 8 chunks +8 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
D Source/core/rendering/RenderMultiColumnBlock.h View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/core/rendering/RenderMultiColumnBlock.cpp View 1 chunk +0 lines, -200 lines 0 comments Download
D Source/core/rendering/RenderMultiColumnFlowThread.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D Source/core/rendering/RenderMultiColumnSet.h View 1 chunk +0 lines, -160 lines 0 comments Download
D Source/core/rendering/RenderMultiColumnSet.cpp View 1 chunk +0 lines, -515 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowFragment.h View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowFragment.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowThread.h View 1 chunk +0 lines, -144 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowThread.cpp View 1 chunk +0 lines, -730 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 12 chunks +2 lines, -53 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 16 chunks +4 lines, -152 lines 0 comments Download
D Source/core/rendering/RenderRegion.h View 1 chunk +0 lines, -229 lines 0 comments Download
D Source/core/rendering/RenderRegion.cpp View 1 chunk +0 lines, -688 lines 0 comments Download
D Source/core/rendering/RenderRegionSet.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/rendering/RenderRegionSet.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M Source/core/rendering/RenderReplica.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 5 chunks +1 line, -96 lines 0 comments Download
M Source/core/rendering/RenderView.h View 8 chunks +1 line, -17 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 8 chunks +3 lines, -129 lines 0 comments Download
M Source/core/rendering/RootInlineBox.h View 4 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 3 chunks +1 line, -25 lines 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/line/LineLayoutState.h View 4 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 6 chunks +1 line, -25 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/Inspector-1.1.json View 3 chunks +0 lines, -67 lines 0 comments Download
M Source/devtools/devtools.gypi View 4 chunks +0 lines, -7 lines 0 comments Download
D Source/devtools/front_end/CSSNamedFlowCollectionsView.js View 1 chunk +0 lines, -433 lines 0 comments Download
D Source/devtools/front_end/CSSNamedFlowView.js View 1 chunk +0 lines, -256 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 7 chunks +1 line, -233 lines 0 comments Download
M Source/devtools/front_end/ElementsPanel.js View 5 chunks +3 lines, -17 lines 0 comments Download
D Source/devtools/front_end/cssNamedFlows.css View 1 chunk +0 lines, -99 lines 0 comments Download
M Source/devtools/protocol.json View 3 chunks +0 lines, -67 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +0 lines, -2 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit: CQ not working?

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d