Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1240183002: Update SplitString calls in chrome. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, nektar+watch_chromium.org, johnme+watch_chromium.org, browser-components-watch_chromium.org, dmazzoni+watch_chromium.org, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, shishir+watch_chromium.org, tommycli, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, samuong+watch_chromium.org, dzhioev+watch_chromium.org, nona+watch_chromium.org, je_julie, rlp+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, derat+watch_chromium.org, mvanouwerkerk+watch_chromium.org, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, nhiroki, oshima+watch_chromium.org, rouslan+autofillwatch_chromium.org, plundblad+watch_chromium.org, Lei Zhang, tfarina, shuchen+watch_chromium.org, mcasas+watch_chromium.org, asvitkine+watch_chromium.org, aboxhall+watch_chromium.org, eroman, dtseng+watch_chromium.org, wfh+watch_chromium.org, estade+watch_chromium.org, peter+watch_chromium.org, James Su, wjia+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SplitString calls in chrome. In many places that iterated over the results, the code was changed to use a range-based for loop over the result of the SplitStirng call. Committed: https://crrev.com/c6f82b158f374c172a46326699f03d97777faa8e Cr-Commit-Position: refs/heads/master@{#339753}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -463 lines) Patch
M chrome/app/chrome_crash_reporter_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/camera_detector.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.cc View 4 chunks +24 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/language_list.cc View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/power/cpu_data_collector.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/install_signer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/io_thread.cc View 4 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/media/webrtc_log_uploader_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/safe_search_util.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_posix.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_app_identifier.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/chunk_range.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_error_classification.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_error_classification_unittest.cc View 6 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_whitelist_service.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/sxs_linux.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_properties.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/browser/tracing/crash_service_uploader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_result.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/elide_url.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/expanding_textfield.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/upload_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/command.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M chrome/common/pepper_flash.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/secure_origin_whitelist.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/variations/experiment_labels_unittest.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/variations/variations_util.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/installer/gcapi/gcapi_omaha_experiment.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/installer/util/compat_checks.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/installer/util/user_experiment.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/web_apps.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_process_util_mac.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 2 3 chunks +10 lines, -11 lines 0 comments Download
M chrome/test/chromedriver/chrome/browser_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_android_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/element_commands.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/tools/convert_dict/aff_reader.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/utility/importer/bookmark_html_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/utility/importer/nss_decryptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/picasa_albums_indexer.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 37 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/1
5 years, 5 months ago (2015-07-19 20:28:19 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/93746)
5 years, 5 months ago (2015-07-19 20:41:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/20001
5 years, 5 months ago (2015-07-19 21:32:31 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/88939)
5 years, 5 months ago (2015-07-19 21:40:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/40001
5 years, 5 months ago (2015-07-20 05:20:04 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/80014)
5 years, 5 months ago (2015-07-20 05:32:50 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/60001
5 years, 5 months ago (2015-07-20 05:46:12 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/75437)
5 years, 5 months ago (2015-07-20 05:56:22 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/80001
5 years, 5 months ago (2015-07-20 15:45:28 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/80124)
5 years, 5 months ago (2015-07-20 16:11:38 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/100001
5 years, 5 months ago (2015-07-20 17:52:46 UTC) #22
brettw
Weekend project part 2/2
5 years, 5 months ago (2015-07-20 17:57:19 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/60893)
5 years, 5 months ago (2015-07-20 18:20:48 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/120001
5 years, 5 months ago (2015-07-20 18:24:23 UTC) #28
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 19:48:52 UTC) #30
brettw
As requested.
5 years, 5 months ago (2015-07-21 19:11:49 UTC) #32
Elliot Glaysher
spot checked some files. rubber stamp lgtm.
5 years, 5 months ago (2015-07-21 19:18:15 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240183002/120001
5 years, 5 months ago (2015-07-21 20:16:40 UTC) #35
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-21 21:37:50 UTC) #36
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:38:41 UTC) #37
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c6f82b158f374c172a46326699f03d97777faa8e
Cr-Commit-Position: refs/heads/master@{#339753}

Powered by Google App Engine
This is Rietveld 408576698