Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Side by Side Diff: chrome/common/chrome_content_client.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/upload_list.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_content_client.h" 5 #include "chrome/common/chrome_content_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/debug/crash_logging.h" 8 #include "base/debug/crash_logging.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 232
233 content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path, 233 content::PepperPluginInfo CreatePepperFlashInfo(const base::FilePath& path,
234 const std::string& version) { 234 const std::string& version) {
235 content::PepperPluginInfo plugin; 235 content::PepperPluginInfo plugin;
236 236
237 plugin.is_out_of_process = true; 237 plugin.is_out_of_process = true;
238 plugin.name = content::kFlashPluginName; 238 plugin.name = content::kFlashPluginName;
239 plugin.path = path; 239 plugin.path = path;
240 plugin.permissions = chrome::kPepperFlashPermissions; 240 plugin.permissions = chrome::kPepperFlashPermissions;
241 241
242 std::vector<std::string> flash_version_numbers; 242 std::vector<std::string> flash_version_numbers = base::SplitString(
243 base::SplitString(version, '.', &flash_version_numbers); 243 version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
244 if (flash_version_numbers.size() < 1) 244 if (flash_version_numbers.size() < 1)
245 flash_version_numbers.push_back("11"); 245 flash_version_numbers.push_back("11");
246 // |SplitString()| puts in an empty string given an empty string. :(
247 else if (flash_version_numbers[0].empty())
248 flash_version_numbers[0] = "11";
249 if (flash_version_numbers.size() < 2) 246 if (flash_version_numbers.size() < 2)
250 flash_version_numbers.push_back("2"); 247 flash_version_numbers.push_back("2");
251 if (flash_version_numbers.size() < 3) 248 if (flash_version_numbers.size() < 3)
252 flash_version_numbers.push_back("999"); 249 flash_version_numbers.push_back("999");
253 if (flash_version_numbers.size() < 4) 250 if (flash_version_numbers.size() < 4)
254 flash_version_numbers.push_back("999"); 251 flash_version_numbers.push_back("999");
255 // E.g., "Shockwave Flash 10.2 r154": 252 // E.g., "Shockwave Flash 10.2 r154":
256 plugin.description = plugin.name + " " + flash_version_numbers[0] + "." + 253 plugin.description = plugin.name + " " + flash_version_numbers[0] + "." +
257 flash_version_numbers[1] + " r" + flash_version_numbers[2]; 254 flash_version_numbers[1] + " r" + flash_version_numbers[2];
258 plugin.version = base::JoinString(flash_version_numbers, "."); 255 plugin.version = base::JoinString(flash_version_numbers, ".");
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 #endif 575 #endif
579 576
580 void ChromeContentClient::AddSecureSchemesAndOrigins( 577 void ChromeContentClient::AddSecureSchemesAndOrigins(
581 std::set<std::string>* schemes, 578 std::set<std::string>* schemes,
582 std::set<GURL>* origins) { 579 std::set<GURL>* origins) {
583 schemes->insert(content::kChromeUIScheme); 580 schemes->insert(content::kChromeUIScheme);
584 schemes->insert(extensions::kExtensionScheme); 581 schemes->insert(extensions::kExtensionScheme);
585 schemes->insert(extensions::kExtensionResourceScheme); 582 schemes->insert(extensions::kExtensionResourceScheme);
586 GetSecureOriginWhitelist(origins); 583 GetSecureOriginWhitelist(origins);
587 } 584 }
OLDNEW
« no previous file with comments | « chrome/browser/upload_list.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698