chrome/browser/ssl/ssl_error_classification.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_classification.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_error_classification.cc

diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc

index eea89250afa724677523c9a09e001a80b2e5b6ae..5628c64fb9f0d0ade36c8b376828ab56f8f31e67 100644

--- a/chrome/browser/ssl/ssl_error_classification.cc

+++ b/chrome/browser/ssl/ssl_error_classification.cc

@@ -316,9 +316,8 @@ size_t SSLErrorClassification::FindSubDomainDifference(

SSLErrorClassification::Tokens SSLErrorClassification::

Tokenize(const std::string& name) {

- Tokens name_tokens;

- base::SplitStringDontTrim(name, '.', &name_tokens);

- return name_tokens;

+ return base::SplitString(

+ name, ".", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);

}

// We accept the inverse case for www for historical reasons.