Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6117)

Unified Diff: chrome/browser/profiles/profile_downloader.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_downloader.cc
diff --git a/chrome/browser/profiles/profile_downloader.cc b/chrome/browser/profiles/profile_downloader.cc
index cb6dbb234335befab223507626cd8bc24b02316e..5d1c03285be3bc1994901f6c726cc65659db9bc3 100644
--- a/chrome/browser/profiles/profile_downloader.cc
+++ b/chrome/browser/profiles/profile_downloader.cc
@@ -74,8 +74,9 @@ const int kPhotoVersionPathComponentIndex = 3;
// https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s256-c/photo.jpg
bool GetImageURLWithSize(const GURL& old_url, int size, GURL* new_url) {
DCHECK(new_url);
- std::vector<std::string> components;
- base::SplitString(old_url.path(), kURLPathSeparator, &components);
+ std::vector<std::string> components = base::SplitString(
+ old_url.path(), std::string(1, kURLPathSeparator),
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (components.size() == 0)
return false;
@@ -123,10 +124,9 @@ bool ProfileDownloader::IsDefaultProfileImageURL(const std::string& url) {
GURL image_url_object(url);
DCHECK(image_url_object.is_valid());
VLOG(1) << "URL to check for default image: " << image_url_object.spec();
- std::vector<std::string> path_components;
- base::SplitString(image_url_object.path(),
- kURLPathSeparator,
- &path_components);
+ std::vector<std::string> path_components = base::SplitString(
+ image_url_object.path(), std::string(1, kURLPathSeparator),
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (path_components.size() < kProfileImageURLPathComponentsCount)
return false;
« no previous file with comments | « chrome/browser/process_singleton_posix.cc ('k') | chrome/browser/push_messaging/push_messaging_app_identifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698