chrome/service/cloud_print/cloud_print_connector.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_connector.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/cloud_print/cloud_print_connector.cc

diff --git a/chrome/service/cloud_print/cloud_print_connector.cc b/chrome/service/cloud_print/cloud_print_connector.cc

index f53c865e6abe7b2db51ad5b79b70b492f371aaeb..0a7d7542e3976a8b20f23ac237adbe0366550579 100644

--- a/chrome/service/cloud_print/cloud_print_connector.cc

+++ b/chrome/service/cloud_print/cloud_print_connector.cc

@@ -420,8 +420,8 @@ void CloudPrintConnector::InitJobHandlerForPrinter(

if (tags_list->GetString(index, &tag) &&

base::StartsWith(tag, kCloudPrintServiceTagsHashTagName,

base::CompareCase::INSENSITIVE_ASCII)) {

- std::vector<std::string> tag_parts;

- base::SplitStringDontTrim(tag, '=', &tag_parts);

+ std::vector<std::string> tag_parts = base::SplitString(

+ tag, "=", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);

DCHECK_EQ(tag_parts.size(), 2U);

if (tag_parts.size() == 2)

printer_info_cloud.tags_hash = tag_parts[1];

« no previous file with comments | « chrome/renderer/web_apps.cc ('k') | chrome/test/base/chrome_process_util_mac.cc » ('j') | no next file with comments »