Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/test/chromedriver/chrome/chrome_android_impl.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_android_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_android_impl.cc b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
index 5a58e665d109b0ba6a9a254b2b2d14aad73a18fc..5cfcec05e6f1a480c001d4c26fe6f97287af5a1e 100644
--- a/chrome/test/chromedriver/chrome/chrome_android_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_android_impl.cc
@@ -37,8 +37,9 @@ std::string ChromeAndroidImpl::GetOperatingSystemName() {
bool ChromeAndroidImpl::HasTouchScreen() const {
const BrowserInfo* browser_info = GetBrowserInfo();
if (browser_info->browser_name == "webview") {
- std::vector<std::string> version_parts;
- base::SplitString(browser_info->browser_version, '.', &version_parts);
+ std::vector<base::StringPiece> version_parts = base::SplitStringPiece(
+ browser_info->browser_version, ".",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
int major_version;
if (version_parts.size() != 4 ||
!base::StringToInt(version_parts[0], &major_version)) {
« no previous file with comments | « chrome/test/chromedriver/chrome/browser_info.cc ('k') | chrome/test/chromedriver/chrome_launcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698