chrome/browser/chromeos/preferences_unittest.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/preferences_unittest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/preferences_unittest.cc

diff --git a/chrome/browser/chromeos/preferences_unittest.cc b/chrome/browser/chromeos/preferences_unittest.cc

index f790cba1bc5645a6a206f397338719e01517a6ea..3d391efc3c4e12538e1cc3bb77472f1927720a37 100644

--- a/chrome/browser/chromeos/preferences_unittest.cc

+++ b/chrome/browser/chromeos/preferences_unittest.cc

@@ -340,8 +340,8 @@ class InputMethodPreferencesTest : public PreferencesTest {

// Translates engine IDs in a CSV string to input method IDs.

std::string ToInputMethodIds(std::string value) {

- std::vector<std::string> tokens;

- base::SplitString(value, ',', &tokens);

+ std::vector<std::string> tokens = base::SplitString(

+ value, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

std::transform(tokens.begin(), tokens.end(), tokens.begin(),

&extension_ime_util::GetInputMethodIDByEngineID);

return base::JoinString(tokens, ",");