chrome/test/chromedriver/chrome/browser_info.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/browser_info.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/browser_info.cc

diff --git a/chrome/test/chromedriver/chrome/browser_info.cc b/chrome/test/chromedriver/chrome/browser_info.cc

index 23782f2dc960611062784fa5585fa1518378cc13..4f79ee3b02541ca28a867494d10117c910cd827b 100644

--- a/chrome/test/chromedriver/chrome/browser_info.cc

+++ b/chrome/test/chromedriver/chrome/browser_info.cc

@@ -77,8 +77,8 @@ Status ParseBrowserString(bool has_android_package,

int build_no = 0;

if (browser_string.find(kVersionPrefix) == 0u) {

std::string version = browser_string.substr(kVersionPrefix.length());

- std::vector<std::string> version_parts;

- base::SplitString(version, '.', &version_parts);

+ std::vector<base::StringPiece> version_parts = base::SplitStringPiece(

+ version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (version_parts.size() != 4 ||

!base::StringToInt(version_parts[2], &build_no)) {