Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: chrome/browser/chromeos/login/language_list.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/language_list.cc
diff --git a/chrome/browser/chromeos/login/language_list.cc b/chrome/browser/chromeos/login/language_list.cc
index f6bf2510d255bc859bdf412235001e907dbbad7d..9e395392b2cbb7d223c1d5294aa6b2c93ba762a0 100644
--- a/chrome/browser/chromeos/login/language_list.cc
+++ b/chrome/browser/chromeos/login/language_list.cc
@@ -78,10 +78,9 @@ int LanguageList::GetIndexFromLocale(const std::string& locale) const {
void LanguageList::CopySpecifiedLanguagesUp(const std::string& locale_codes) {
DCHECK(!locale_names_.empty());
- std::vector<std::string> locale_codes_vector;
- base::SplitString(locale_codes, ',', &locale_codes_vector);
- for (size_t i = 0; i != locale_codes_vector.size(); ++i) {
- const int locale_index = GetIndexFromLocale(locale_codes_vector[i]);
+ for (const std::string& code : base::SplitString(
+ locale_codes, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ const int locale_index = GetIndexFromLocale(code);
CHECK_NE(locale_index, -1);
locale_names_.insert(locale_names_.begin(), locale_names_[locale_index]);
}
« no previous file with comments | « chrome/browser/chromeos/login/chrome_restart_request.cc ('k') | chrome/browser/chromeos/power/cpu_data_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698