Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7314)

Unified Diff: chrome/common/variations/variations_util.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/variations/variations_util.cc
diff --git a/chrome/common/variations/variations_util.cc b/chrome/common/variations/variations_util.cc
index ff7bc5d6cd0dee40dd8ccb095dd83f9d0d7f926d..3c283368c91acac9df913587c0eca2336d12e763 100644
--- a/chrome/common/variations/variations_util.cc
+++ b/chrome/common/variations/variations_util.cc
@@ -34,21 +34,21 @@ void SetChildProcessLoggingVariationList() {
bool AssociateParamsFromString(const std::string& varations_string) {
// Format: Trial1.Group1:k1/v1/k2/v2,Trial2.Group2:k1/v1/k2/v2
- std::vector<std::string> experiment_groups;
- base::SplitString(varations_string, ',', &experiment_groups);
- for (const auto& experiment_group : experiment_groups) {
- std::vector<std::string> experiment;
- base::SplitString(experiment_group, ':', &experiment);
+ for (const base::StringPiece& experiment_group : base::SplitStringPiece(
+ varations_string, ",",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ std::vector<base::StringPiece> experiment = base::SplitStringPiece(
+ experiment_group, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (experiment.size() != 2)
return false;
- std::vector<std::string> group_parts;
- base::SplitString(experiment[0], '.', &group_parts);
+ std::vector<std::string> group_parts = base::SplitString(
+ experiment[0], ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (group_parts.size() != 2)
return false;
- std::vector<std::string> key_values;
- base::SplitString(experiment[1], '/', &key_values);
+ std::vector<std::string> key_values = base::SplitString(
+ experiment[1], "/", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (key_values.size() % 2 != 0)
return false;
« no previous file with comments | « chrome/common/variations/experiment_labels_unittest.cc ('k') | chrome/installer/gcapi/gcapi_omaha_experiment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698