chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

diff --git a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc b/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

index d97fca421a354df4ef0c68eb321a3e3e70f60625..825c87c28f3250946d880044865813820fe3d535 100644

--- a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

+++ b/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

@@ -52,8 +52,8 @@ GaiaWebAuthFlow::GaiaWebAuthFlow(Delegate* delegate,

std::vector<std::string> scopes(token_key->scopes.begin(),

token_key->scopes.end());

- std::vector<std::string> client_id_parts;

- base::SplitString(oauth2_client_id, '.', &client_id_parts);

+ std::vector<std::string> client_id_parts = base::SplitString(

+ oauth2_client_id, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

std::reverse(client_id_parts.begin(), client_id_parts.end());

redirect_scheme_ = base::JoinString(client_id_parts, ".");

std::string signin_scoped_device_id;