chrome/browser/chromeos/customization/customization_document_browsertest.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/customization/customization_document_browsertest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/customization/customization_document.cc ('k') | chrome/browser/chromeos/display/display_preferences.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/customization/customization_document_browsertest.cc

diff --git a/chrome/browser/chromeos/customization/customization_document_browsertest.cc b/chrome/browser/chromeos/customization/customization_document_browsertest.cc

index 7ba8243ddf07aa9828557f52cfbd98d5b0f572c3..fc61d5d6bfa18ed71e37c72a8e1a6ee6bde350ab 100644

--- a/chrome/browser/chromeos/customization/customization_document_browsertest.cc

+++ b/chrome/browser/chromeos/customization/customization_document_browsertest.cc

@@ -215,8 +215,8 @@ class CustomizationVPDTest : public InProcessBrowserTest,

};

IN_PROC_BROWSER_TEST_P(CustomizationVPDTest, GetUILanguageList) {

- std::vector<std::string> locales;

- base::SplitString(GetParam(), ',', &locales);

+ std::vector<std::string> locales = base::SplitString(

+ GetParam(), ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

for (std::string& l : locales) {

base::TrimString(l, " ", &l);