Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2964)

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_apitest.cc
diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc
index 48ddbaf863a8a3ae6affa229c4f3317fe7c7f9af..261ee75355bd0f3a42470791faf6aacf7d9eb847 100644
--- a/chrome/browser/extensions/extension_apitest.cc
+++ b/chrome/browser/extensions/extension_apitest.cc
@@ -94,11 +94,9 @@ scoped_ptr<net::test_server::HttpResponse> HandleSetCookieRequest(
std::string cookie_value =
request.relative_url.substr(query_string_pos + 1);
- std::vector<std::string> cookies;
- base::SplitString(cookie_value, '&', &cookies);
-
- for (size_t i = 0; i < cookies.size(); i++)
- http_response->AddCustomHeader("Set-Cookie", cookies[i]);
+ for (const std::string& cookie : base::SplitString(
+ cookie_value, "&", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL))
+ http_response->AddCustomHeader("Set-Cookie", cookie);
return http_response.Pass();
}
« no previous file with comments | « chrome/browser/extensions/api/log_private/log_parser.cc ('k') | chrome/browser/extensions/install_signer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698