chrome/browser/push_messaging/push_messaging_app_identifier.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_app_identifier.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_app_identifier.cc

diff --git a/chrome/browser/push_messaging/push_messaging_app_identifier.cc b/chrome/browser/push_messaging/push_messaging_app_identifier.cc

index fa15b9468950343944fa1adca15aa74ae085b2d5..cfb8c5f1732b1d9a9f7c857acef0acd07b082c80 100644

--- a/chrome/browser/push_messaging/push_messaging_app_identifier.cc

+++ b/chrome/browser/push_messaging/push_messaging_app_identifier.cc

@@ -37,8 +37,9 @@ std::string MakePrefValue(const GURL& origin,

bool GetOriginAndSWRFromPrefValue(

const std::string& pref_value, GURL* origin,

int64_t* service_worker_registration_id) {

- std::vector<std::string> parts;

- base::SplitString(pref_value, kSeparator, &parts);

+ std::vector<std::string> parts = base::SplitString(

+ pref_value, std::string(1, kSeparator),

+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (parts.size() != 2)

return false;