Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/test/chromedriver/chrome_launcher_unittest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome_launcher_unittest.cc
diff --git a/chrome/test/chromedriver/chrome_launcher_unittest.cc b/chrome/test/chromedriver/chrome_launcher_unittest.cc
index 5ccec7c90afddb70c04d196291922127f0bdfc1f..ec8f7a10170475ca6b4b07c6db18d05a082db619 100644
--- a/chrome/test/chromedriver/chrome_launcher_unittest.cc
+++ b/chrome/test/chromedriver/chrome_launcher_unittest.cc
@@ -124,8 +124,9 @@ TEST(ProcessExtensions, MultipleExtensionsNoBgPages) {
ASSERT_TRUE(switches.HasSwitch("load-extension"));
base::CommandLine::StringType ext_paths =
switches.GetSwitchValueNative("load-extension");
- std::vector<base::CommandLine::StringType> ext_path_list;
- base::SplitString(ext_paths, FILE_PATH_LITERAL(','), &ext_path_list);
+ std::vector<base::CommandLine::StringType> ext_path_list =
+ base::SplitString(ext_paths, base::CommandLine::StringType(1, ','),
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
ASSERT_EQ(2u, ext_path_list.size());
ASSERT_TRUE(base::PathExists(base::FilePath(ext_path_list[0])));
ASSERT_TRUE(base::PathExists(base::FilePath(ext_path_list[1])));
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_android_impl.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698