chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc

diff --git a/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc b/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc

index 491a8f2d23bc9bd973217c51a5b2dee00652821a..08809ded8e7905613cfbdafbd361a970d7d5a333 100644

--- a/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc

+++ b/chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc

@@ -125,9 +125,9 @@ TEST(SpellcheckWordIteratorTest, SplitWord) {

kTestCases[i].allow_contraction));

EXPECT_TRUE(iterator.SetText(input.c_str(), input.length()));

- std::vector<base::string16> expected_words;

- base::SplitString(

- base::WideToUTF16(kTestCases[i].expected_words), ' ', &expected_words);

+ std::vector<base::string16> expected_words = base::SplitString(

+ base::WideToUTF16(kTestCases[i].expected_words),

+ base::string16(1, ' '), base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

base::string16 actual_word;

int actual_start, actual_end;