chrome/test/chromedriver/capabilities.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/capabilities.cc

diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc

index 33b34d26cc5e76f8e98cd86f63bd4b61685aae7d..bc5bbbb960964f13e821a214683280b216153e9b 100644

--- a/chrome/test/chromedriver/capabilities.cc

+++ b/chrome/test/chromedriver/capabilities.cc

@@ -294,8 +294,8 @@ Status ParseUseRemoteBrowser(const base::Value& option,

if (!option.GetAsString(&server_addr))

return Status(kUnknownError, "must be 'host:port'");

- std::vector<std::string> values;

- base::SplitString(server_addr, ':', &values);

+ std::vector<std::string> values = base::SplitString(

+ server_addr, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (values.size() != 2)

return Status(kUnknownError, "must be 'host:port'");