chrome/browser/ui/webui/print_preview/print_preview_ui.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

index 6cd974b7af8dcaa866dec2b1d415bd667face29e..ad53e9a6d0fa99bb48a3be9ef8e87351eba8b065 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

@@ -129,8 +129,8 @@ bool HandleRequestCallback(

// Print Preview data.

scoped_refptr<base::RefCountedBytes> data;

- std::vector<std::string> url_substr;

- base::SplitString(path, '/', &url_substr);

+ std::vector<std::string> url_substr = base::SplitString(

+ path, "/", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

int preview_ui_id = -1;

int page_index = 0;

if (url_substr.size() == 3 &&