chrome/browser/net/predictor.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/predictor.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/predictor.cc

diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc

index 0241aa0d39cdfdbf457a440cd3ff8243d68d6de5..d18979a891f0814bf1462a6c0482b02b68142a7d 100644

--- a/chrome/browser/net/predictor.cc

+++ b/chrome/browser/net/predictor.cc

@@ -501,8 +501,8 @@ struct RightToLeftStringSorter {

// "http://com.google.www/xyz".

static std::string ReverseComponents(const GURL& url) {

// Reverse the components in the hostname.

- std::vector<std::string> parts;

- base::SplitString(url.host(), '.', &parts);

+ std::vector<std::string> parts = base::SplitString(

+ url.host(), ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

std::reverse(parts.begin(), parts.end());

std::string reversed_host = base::JoinString(parts, ".");