chrome/test/chromedriver/server/http_handler.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 0d54c220505ab675e3dce797dbf9f132b864c787..63c0a95bcaddd7eed308e25006d7df35831d81d8 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -742,10 +742,10 @@ bool MatchesCommand(const std::string& method,

if (!MatchesMethod(command.method, method))

return false;

- std::vector<std::string> path_parts;

- base::SplitString(path, '/', &path_parts);

- std::vector<std::string> command_path_parts;

- base::SplitString(command.path_pattern, '/', &command_path_parts);

+ std::vector<std::string> path_parts = base::SplitString(

+ path, "/", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ std::vector<std::string> command_path_parts = base::SplitString(

+ command.path_pattern, "/", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (path_parts.size() != command_path_parts.size())

return false;