chrome/browser/translate/chrome_translate_client.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/chrome_translate_client.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/translate/chrome_translate_client.cc

diff --git a/chrome/browser/translate/chrome_translate_client.cc b/chrome/browser/translate/chrome_translate_client.cc

index f61f5e725b5c9fe6d0738a6e56c18c7c5ce4f01d..c16a64a5578f9539b7cc97755ee625820c9770d7 100644

--- a/chrome/browser/translate/chrome_translate_client.cc

+++ b/chrome/browser/translate/chrome_translate_client.cc

@@ -152,8 +152,8 @@ void ChromeTranslateClient::GetTranslateLanguages(

}

std::string accept_languages_str = prefs->GetString(prefs::kAcceptLanguages);

- std::vector<std::string> accept_languages_list;

- base::SplitString(accept_languages_str, ',', &accept_languages_list);

+ std::vector<std::string> accept_languages_list = base::SplitString(

+ accept_languages_str, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

*target =

translate::TranslateManager::GetTargetLanguage(accept_languages_list);

}