Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4739)

Unified Diff: chrome/installer/util/compat_checks.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/gcapi/gcapi_omaha_experiment.cc ('k') | chrome/installer/util/user_experiment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/compat_checks.cc
diff --git a/chrome/installer/util/compat_checks.cc b/chrome/installer/util/compat_checks.cc
index 52a70a68e9f4a89bc4f24de005efde6344e45946..d2425e88d2ce73ab6da6a58be61f070797962c6a 100644
--- a/chrome/installer/util/compat_checks.cc
+++ b/chrome/installer/util/compat_checks.cc
@@ -26,9 +26,10 @@ std::wstring GetSEPVersion() {
// The product version should be a string like "11.0.3001.2224". This function
// returns as params the first 3 values. Return value is false if anything
// does not fit the format.
-bool ParseSEPVersion(const std::wstring& version, int* v0, int* v1, int* v2) {
- std::vector<std::wstring> v;
- base::SplitString(version, L'.', &v);
+bool ParseSEPVersion(const base::string16& version,
+ int* v0, int* v1, int* v2) {
+ std::vector<base::StringPiece16> v = base::SplitStringPiece(
+ version, L".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (v.size() != 4)
return false;
if (!base::StringToInt(v[0], v0))
« no previous file with comments | « chrome/installer/gcapi/gcapi_omaha_experiment.cc ('k') | chrome/installer/util/user_experiment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698