Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/translate/translate_service.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_service.h" 5 #include "chrome/browser/translate/translate_service.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 return base::CommandLine::ForCurrentProcess()->HasSwitch( 100 return base::CommandLine::ForCurrentProcess()->HasSwitch(
101 switches::kEnableTranslateNewUX); 101 switches::kEnableTranslateNewUX);
102 #else 102 #else
103 // The bubble UX is not implemented on other platforms. 103 // The bubble UX is not implemented on other platforms.
104 return false; 104 return false;
105 #endif 105 #endif
106 } 106 }
107 107
108 // static 108 // static
109 std::string TranslateService::GetTargetLanguage(PrefService* prefs) { 109 std::string TranslateService::GetTargetLanguage(PrefService* prefs) {
110 std::vector<std::string> accept_languages_list; 110 std::vector<std::string> accept_languages_list = base::SplitString(
111 base::SplitString(prefs->GetString(prefs::kAcceptLanguages), ',', 111 prefs->GetString(prefs::kAcceptLanguages), ",",
112 &accept_languages_list); 112 base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
113 return translate::TranslateManager::GetTargetLanguage(accept_languages_list); 113 return translate::TranslateManager::GetTargetLanguage(accept_languages_list);
114 } 114 }
115 115
116 // static 116 // static
117 bool TranslateService::IsTranslatableURL(const GURL& url) { 117 bool TranslateService::IsTranslatableURL(const GURL& url) {
118 // A URLs is translatable unless it is one of the following: 118 // A URLs is translatable unless it is one of the following:
119 // - empty (can happen for popups created with window.open("")) 119 // - empty (can happen for popups created with window.open(""))
120 // - an internal URL (chrome:// and others) 120 // - an internal URL (chrome:// and others)
121 // - the devtools (which is considered UI) 121 // - the devtools (which is considered UI)
122 // - Chrome OS file manager extension 122 // - Chrome OS file manager extension
123 // - an FTP page (as FTP pages tend to have long lists of filenames that may 123 // - an FTP page (as FTP pages tend to have long lists of filenames that may
124 // confuse the CLD) 124 // confuse the CLD)
125 return !url.is_empty() && !url.SchemeIs(content::kChromeUIScheme) && 125 return !url.is_empty() && !url.SchemeIs(content::kChromeUIScheme) &&
126 !url.SchemeIs(content::kChromeDevToolsScheme) && 126 !url.SchemeIs(content::kChromeDevToolsScheme) &&
127 #if defined(OS_CHROMEOS) 127 #if defined(OS_CHROMEOS)
128 !(url.SchemeIs(extensions::kExtensionScheme) && 128 !(url.SchemeIs(extensions::kExtensionScheme) &&
129 url.DomainIs(file_manager::kFileManagerAppId)) && 129 url.DomainIs(file_manager::kFileManagerAppId)) &&
130 #endif 130 #endif
131 !url.SchemeIs(url::kFtpScheme); 131 !url.SchemeIs(url::kFtpScheme);
132 } 132 }
OLDNEW
« no previous file with comments | « chrome/browser/translate/chrome_translate_client.cc ('k') | chrome/browser/ui/android/autofill/autofill_dialog_result.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698