Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5177)

Unified Diff: chrome/browser/safe_browsing/chunk_range.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chunk_range.cc
diff --git a/chrome/browser/safe_browsing/chunk_range.cc b/chrome/browser/safe_browsing/chunk_range.cc
index 6e5c3f88d8be3bee44fdd39c297b69e4273f0de1..024aa9b3c8b786dc70016d38f0470e36038f0424 100644
--- a/chrome/browser/safe_browsing/chunk_range.cc
+++ b/chrome/browser/safe_browsing/chunk_range.cc
@@ -69,12 +69,10 @@ bool StringToRanges(const std::string& input,
// Crack the string into chunk parts, then crack each part looking for a
// range.
- std::vector<std::string> chunk_parts;
- base::SplitString(input, ',', &chunk_parts);
-
- for (size_t i = 0; i < chunk_parts.size(); ++i) {
- std::vector<std::string> chunk_ranges;
- base::SplitString(chunk_parts[i], '-', &chunk_ranges);
+ for (const base::StringPiece& chunk : base::SplitStringPiece(
+ input, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ std::vector<std::string> chunk_ranges = base::SplitString(
+ chunk, "-", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
int start = atoi(chunk_ranges[0].c_str());
int stop = start;
if (chunk_ranges.size() == 2)
« no previous file with comments | « chrome/browser/push_messaging/push_messaging_app_identifier.cc ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698