Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: chrome/installer/util/compat_checks.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/compat_checks.h" 5 #include "chrome/installer/util/compat_checks.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_split.h" 8 #include "base/strings/string_split.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/win/registry.h" 10 #include "base/win/registry.h"
11 11
12 namespace { 12 namespace {
13 13
14 // SEP stands for Symantec End Point Protection. 14 // SEP stands for Symantec End Point Protection.
15 std::wstring GetSEPVersion() { 15 std::wstring GetSEPVersion() {
16 const wchar_t kProductKey[] = 16 const wchar_t kProductKey[] =
17 L"SOFTWARE\\Symantec\\Symantec Endpoint Protection\\SMC"; 17 L"SOFTWARE\\Symantec\\Symantec Endpoint Protection\\SMC";
18 // Versions before 11MR3 were always 32-bit, so check in the 32-bit hive. 18 // Versions before 11MR3 were always 32-bit, so check in the 32-bit hive.
19 base::win::RegKey key( 19 base::win::RegKey key(
20 HKEY_LOCAL_MACHINE, kProductKey, KEY_READ | KEY_WOW64_32KEY); 20 HKEY_LOCAL_MACHINE, kProductKey, KEY_READ | KEY_WOW64_32KEY);
21 std::wstring version_str; 21 std::wstring version_str;
22 key.ReadValue(L"ProductVersion", &version_str); 22 key.ReadValue(L"ProductVersion", &version_str);
23 return version_str; 23 return version_str;
24 } 24 }
25 25
26 // The product version should be a string like "11.0.3001.2224". This function 26 // The product version should be a string like "11.0.3001.2224". This function
27 // returns as params the first 3 values. Return value is false if anything 27 // returns as params the first 3 values. Return value is false if anything
28 // does not fit the format. 28 // does not fit the format.
29 bool ParseSEPVersion(const std::wstring& version, int* v0, int* v1, int* v2) { 29 bool ParseSEPVersion(const base::string16& version,
30 std::vector<std::wstring> v; 30 int* v0, int* v1, int* v2) {
31 base::SplitString(version, L'.', &v); 31 std::vector<base::StringPiece16> v = base::SplitStringPiece(
32 version, L".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
32 if (v.size() != 4) 33 if (v.size() != 4)
33 return false; 34 return false;
34 if (!base::StringToInt(v[0], v0)) 35 if (!base::StringToInt(v[0], v0))
35 return false; 36 return false;
36 if (!base::StringToInt(v[1], v1)) 37 if (!base::StringToInt(v[1], v1))
37 return false; 38 return false;
38 if (!base::StringToInt(v[2], v2)) 39 if (!base::StringToInt(v[2], v2))
39 return false; 40 return false;
40 return true; 41 return true;
41 } 42 }
(...skipping 11 matching lines...) Expand all
53 54
54 } // namespace 55 } // namespace
55 56
56 bool HasIncompatibleSymantecEndpointVersion(const wchar_t* version) { 57 bool HasIncompatibleSymantecEndpointVersion(const wchar_t* version) {
57 int v0, v1, v2; 58 int v0, v1, v2;
58 std::wstring ver_str(version ? version : GetSEPVersion()); 59 std::wstring ver_str(version ? version : GetSEPVersion());
59 if (!ParseSEPVersion(ver_str, &v0, &v1, &v2)) 60 if (!ParseSEPVersion(ver_str, &v0, &v1, &v2))
60 return false; 61 return false;
61 return IsBadSEPVersion(v0, v1, v2); 62 return IsBadSEPVersion(v0, v1, v2);
62 } 63 }
OLDNEW
« no previous file with comments | « chrome/installer/gcapi/gcapi_omaha_experiment.cc ('k') | chrome/installer/util/user_experiment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698