chrome/common/service_process_util_unittest.cc - Issue 1240183002: Update SplitString calls in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/service_process_util_unittest.cc

diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc

index 14af917e191bf8ddd0d9fa01c92438d849e1c7b5..11c9b1ac4b68517e7d59a21faeb5e9b009e463e3 100644

--- a/chrome/common/service_process_util_unittest.cc

+++ b/chrome/common/service_process_util_unittest.cc

@@ -150,8 +150,9 @@ TEST_F(ServiceProcessStateTest, AutoRun) {

ASSERT_EQ(std::string::npos, exec_value.find('"'));

ASSERT_EQ(std::string::npos, exec_value.find('\''));

- base::CommandLine::StringVector argv;

- base::SplitString(exec_value, ' ', &argv);

+ base::CommandLine::StringVector argv = base::SplitString(

+ exec_value, base::CommandLine::StringType(1, ' '),

+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

ASSERT_GE(argv.size(), 2U)

<< "Expected at least one command-line option in: " << exec_value;

autorun_command_line.reset(new base::CommandLine(argv));