Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: chrome/browser/extensions/api/commands/command_service.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/commands/command_service.cc
diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc
index 7636c93d2188b1096fd14dff98e2b630ceceebd9..5ff87113ecf42f457c2a7786281829ec947d1b49 100644
--- a/chrome/browser/extensions/api/commands/command_service.cc
+++ b/chrome/browser/extensions/api/commands/command_service.cc
@@ -389,12 +389,12 @@ Command CommandService::FindCommandByName(const std::string& extension_id,
bool global = false;
item->GetBoolean(kGlobal, &global);
- std::vector<std::string> tokens;
- base::SplitString(shortcut, ':', &tokens);
+ std::vector<base::StringPiece> tokens = base::SplitStringPiece(
+ shortcut, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
CHECK(tokens.size() >= 2);
- shortcut = tokens[1];
- return Command(command_name, base::string16(), shortcut, global);
+ return Command(command_name, base::string16(), tokens[1].as_string(),
+ global);
}
return Command();
« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698