Rebased PNaCl localmods in LLVM to 223109

Rebased PNaCl localmods in LLVM to 223109

depot_tools/third_party/upload.py --server codereview.chromium.org 51c1c423a9061345763425845c283b56caf4176b

[JF, 2015-02-24 17:25:43]

jfb@chromium.org changed reviewers:
+ jfb@chromium.org

[JF, 2015-02-24 17:25:47]

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h
File include/llvm/ADT/Triple.h (right):

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h#ne...
include/llvm/ADT/Triple.h:240: EnvironmentType getEnvironment() const { return
Environment; }
Move LOCALMOD marker.

[jvoung (off chromium), 2015-02-24 18:49:10]

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h
File include/llvm/ADT/Triple.h (right):

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h#ne...
include/llvm/ADT/Triple.h:240: EnvironmentType getEnvironment() const { return
Environment; }
On 2015/02/24 17:25:47, JF wrote:
> Move LOCALMOD marker.

Wow, well spotted ;-)

Apparently, this isn't a localmod, but I accidentally swapped hasEnvironment and
getEnvironment. Swapped back.

[JF, 2015-02-24 19:34:05]

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h
File include/llvm/ADT/Triple.h (right):

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h#ne...
include/llvm/ADT/Triple.h:240: EnvironmentType getEnvironment() const { return
Environment; }
On 2015/02/24 18:49:10, jvoung wrote:
> On 2015/02/24 17:25:47, JF wrote:
> > Move LOCALMOD marker.
> 
> Wow, well spotted ;-)
> 
> Apparently, this isn't a localmod, but I accidentally swapped hasEnvironment
and
> getEnvironment. Swapped back.

I think Jim calls this "pulling a Jan" ;-)

[Jim Stichnoth, 2015-02-25 17:26:04]

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h
File include/llvm/ADT/Triple.h (right):

https://codereview.chromium.org/939073008/diff/1/include/llvm/ADT/Triple.h#ne...
include/llvm/ADT/Triple.h:240: EnvironmentType getEnvironment() const { return
Environment; }
On 2015/02/24 19:34:05, JF wrote:
> On 2015/02/24 18:49:10, jvoung wrote:
> > On 2015/02/24 17:25:47, JF wrote:
> > > Move LOCALMOD marker.
> > 
> > Wow, well spotted ;-)
> > 
> > Apparently, this isn't a localmod, but I accidentally swapped hasEnvironment
> and
> > getEnvironment. Swapped back.
> 
> I think Jim calls this "pulling a Jan" ;-)

Ah, so Jan pulled a Jim, and then JF pulled a Jan.
(Yo dawg?  We must go deeper?)