Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: lib/CodeGen/LexicalScopes.cpp

Issue 939073008: Rebased PNaCl localmods in LLVM to 223109 (Closed)
Patch Set: undo localmod Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/CodeGen/LLVMTargetMachine.cpp ('k') | lib/IR/CMakeLists.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/CodeGen/LexicalScopes.cpp
diff --git a/lib/CodeGen/LexicalScopes.cpp b/lib/CodeGen/LexicalScopes.cpp
index b621e3baee513ee37eb8d8343b53e65cbbc55540..234bd1fff36bba0eea148e51b8170a84664a37e3 100644
--- a/lib/CodeGen/LexicalScopes.cpp
+++ b/lib/CodeGen/LexicalScopes.cpp
@@ -176,8 +176,17 @@ LexicalScope *LexicalScopes::getOrCreateRegularScope(MDNode *Scope) {
if (!Parent) {
assert(DIDescriptor(Scope).isSubprogram());
- assert(DISubprogram(Scope).describes(MF->getFunction()));
- assert(!CurrentFnLexicalScope);
+ // @LOCALMOD-BEGIN
+ // This currently asserts when mixing -g and -g0 compilation
+ // units + LTO. Debug info from a few inlined functions are not
+ // marked as inline, so we end up in getOrCreateRegularScope
+ // instead of getOrCreateInlinedScope.
+ // This is reproducible w/ the pnacl-llc.nexe build and
+ // setting the env var PNACL_PRUNE=false.
+ // https://code.google.com/p/nativeclient/issues/detail?id=4026
+ //assert(DISubprogram(Scope).describes(MF->getFunction()));
+ //assert(!CurrentFnLexicalScope);
+ // @LOCALMOD-END
CurrentFnLexicalScope = &I->second;
}
« no previous file with comments | « lib/CodeGen/LLVMTargetMachine.cpp ('k') | lib/IR/CMakeLists.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698