"NULL !=" = NULL

"NULL !=" = NULL

Committed: https://skia.googlesource.com/skia/+/49f085dddff10473b6ebf832a974288300224e60

[bsalomon, 2014-09-05 18:41:23]

bsalomon@google.com changed reviewers:
+ reed@google.com

[bsalomon, 2014-09-05 18:41:26]

For your viewing pleasure.

[tfarina, 2014-09-05 19:18:07]

How was this automated? clang-plugin? sed?

Could you put the command line used to generate this in the CL description?

[bsalomon, 2014-09-05 19:22:48]

On 2014/09/05 19:18:07, tfarina wrote:
> How was this automated? clang-plugin? sed?
> 
> Could you put the command line used to generate this in the CL description?

Visual Studio Ctrl-Shift-H search for "NULL != " replace with "". Similar for
"NULL!=".

Followed up with git grep "NULL !=" and manual deletion to cover the few files
not in the VS solution. Ignored the several files in experimental/ that
contained "NULL !=". git grep for "NULL!=" showed nothing.

Manually added SkToBool() where required to avoid warnings with cl.exe.

[bsalomon, 2014-09-05 19:22:54]

On 2014/09/05 19:18:07, tfarina wrote:
> How was this automated? clang-plugin? sed?
> 
> Could you put the command line used to generate this in the CL description?

Visual Studio Ctrl-Shift-H search for "NULL != " replace with "". Similar for
"NULL!=".

Followed up with git grep "NULL !=" and manual deletion to cover the few files
not in the VS solution. Ignored the several files in experimental/ that
contained "NULL !=". git grep for "NULL!=" showed nothing.

Manually added SkToBool() where required to avoid warnings with cl.exe.

[reed1, 2014-09-05 20:03:14]

lgtm

[bsalomon, 2014-09-05 20:10:02]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-05 20:10:11]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/544233002/40001

[commit-bot: I haz the power, 2014-09-05 20:34:08]

Committed patchset #3 (id:40001) as 49f085dddff10473b6ebf832a974288300224e60

[tfarina, 2014-09-07 01:30:47]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-09-07 01:30:49]

lgtm



Could we update the NULL, 0 section in
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...