src/core/SkImageGenerator.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageGenerator.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageGenerator.cpp

diff --git a/src/core/SkImageGenerator.cpp b/src/core/SkImageGenerator.cpp

index 551d8f78dcbd5fc19fed76cd5893642a26910730..7008e7b42f6dd06c367474effdc7b734fd27625d 100644

--- a/src/core/SkImageGenerator.cpp

+++ b/src/core/SkImageGenerator.cpp

@@ -60,10 +60,10 @@ bool SkImageGenerator::getPixels(const SkImageInfo& info, void* pixels, size_t r

bool SkImageGenerator::getYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3]) {

#ifdef SK_DEBUG

// In all cases, we need the sizes array

- SkASSERT(NULL != sizes);

+ SkASSERT(sizes);

- bool isValidWithPlanes = (NULL != planes) && (NULL != rowBytes) &&

- ((NULL != planes[0]) && (NULL != planes[1]) && (NULL != planes[2]) &&

+ bool isValidWithPlanes = (planes) && (rowBytes) &&

+ ((planes[0]) && (planes[1]) && (planes[2]) &&

(0 != rowBytes[0]) && (0 != rowBytes[1]) && (0 != rowBytes[2]));

bool isValidWithoutPlanes =

((NULL == planes) ||

« no previous file with comments | « src/core/SkGlyphCache.cpp ('k') | src/core/SkMallocPixelRef.cpp » ('j') | no next file with comments »