debugger/SkDebugger.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: debugger/SkDebugger.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: debugger/SkDebugger.cpp

diff --git a/debugger/SkDebugger.cpp b/debugger/SkDebugger.cpp

index 8833df3e7bd30aed15b5900c61c7c8e04ad88912..b2200433b242726eb8fe8294c02c1bcf08e179f8 100644

--- a/debugger/SkDebugger.cpp

+++ b/debugger/SkDebugger.cpp

@@ -98,7 +98,7 @@ void SkDebugger::getOverviewText(const SkTDArray<double>* typeTimes,

overview->append(SkDrawCommand::GetCommandString((DrawType) i));

overview->append(": ");

overview->appendS32(counts[i]);

- if (NULL != typeTimes && totTime >= 0.0) {

+ if (typeTimes && totTime >= 0.0) {

overview->append(" - ");

overview->appendf("%.2f", (*typeTimes)[i]/(float)numRuns);

overview->append("ms");

@@ -115,7 +115,7 @@ void SkDebugger::getOverviewText(const SkTDArray<double>* typeTimes,

total += counts[i];

}

#ifdef SK_DEBUG

- if (NULL != typeTimes) {

+ if (typeTimes) {

SkASSERT(SkScalarNearlyEqual(SkDoubleToScalar(totPercent),

SkDoubleToScalar(100.0)));

SkASSERT(SkScalarNearlyEqual(SkDoubleToScalar(tempSum),

« no previous file with comments | « debugger/SkDebugger.h ('k') | gm/beziereffects.cpp » ('j') | no next file with comments »