"NULL !=" = NULL

src/views/unix/SkOSWindow_Unix.cpp

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include <X11/Xlib.h>
 #include <X11/Xatom.h>
 #include <X11/XKBlib.h>
@@ skipping 28 matching lines @@
     fUnixWindow.fGLContext = NULL;
     this->initWindow(0, NULL);
     this->resize(WIDTH, HEIGHT);
 }
 
 SkOSWindow::~SkOSWindow() {
     this->closeWindow();
 }
 
 void SkOSWindow::closeWindow() {
-    if (NULL != fUnixWindow.fDisplay) {
+    if (fUnixWindow.fDisplay) {
         this->detach();
-        SkASSERT(NULL != fUnixWindow.fGc);
+        SkASSERT(fUnixWindow.fGc);
         XFreeGC(fUnixWindow.fDisplay, fUnixWindow.fGc);
         fUnixWindow.fGc = NULL;
         XDestroyWindow(fUnixWindow.fDisplay, fUnixWindow.fWin);
         fVi = NULL;
         XCloseDisplay(fUnixWindow.fDisplay);
         fUnixWindow.fDisplay = NULL;
         fMSAASampleCount = 0;
     }
 }
 
 void SkOSWindow::initWindow(int requestedMSAASampleCount, AttachmentInfo* info) {
     if (fMSAASampleCount != requestedMSAASampleCount) {
         this->closeWindow();
     }
     // presence of fDisplay means we already have a window
-    if (NULL != fUnixWindow.fDisplay) {
-        if (NULL != info) {
-            if (NULL != fVi) {
+    if (fUnixWindow.fDisplay) {
+        if (info) {
+            if (fVi) {
                 glXGetConfig(fUnixWindow.fDisplay, fVi, GLX_SAMPLES_ARB, &info->fSampleCount);
                 glXGetConfig(fUnixWindow.fDisplay, fVi, GLX_STENCIL_SIZE, &info->fStencilBits);
             } else {
                 info->fSampleCount = 0;
                 info->fStencilBits = 0;
             }
         }
         return;
     }
     fUnixWindow.fDisplay = XOpenDisplay(NULL);
@@ skipping 23 matching lines @@
         msaaAtt[kAttCount + 3] = None;
         fVi = glXChooseVisual(dsp, DefaultScreen(dsp), msaaAtt);
         fMSAASampleCount = requestedMSAASampleCount;
     }
     if (NULL == fVi) {
         fVi = glXChooseVisual(dsp, DefaultScreen(dsp), att);
         fMSAASampleCount = 0;
     }
 
     if (fVi) {
-        if (NULL != info) {
+        if (info) {
             glXGetConfig(dsp, fVi, GLX_SAMPLES_ARB, &info->fSampleCount);
             glXGetConfig(dsp, fVi, GLX_STENCIL_SIZE, &info->fStencilBits);
         }
         Colormap colorMap = XCreateColormap(dsp,
                                             RootWindow(dsp, fVi->screen),
                                             fVi->visual,
                                              AllocNone);
         XSetWindowAttributes swa;
         swa.colormap = colorMap;
         swa.event_mask = EVENT_MASK;
         fUnixWindow.fWin = XCreateWindow(dsp,
                                          RootWindow(dsp, fVi->screen),
                                          0, 0, // x, y
                                          WIDTH, HEIGHT,
                                          0, // border width
                                          fVi->depth,
                                          InputOutput,
                                          fVi->visual,
                                          CWEventMask | CWColormap,
                                          &swa);
     } else {
-        if (NULL != info) {
+        if (info) {
             info->fSampleCount = 0;
             info->fStencilBits = 0;
         }
         // Create a simple window instead.  We will not be able to show GL
         fUnixWindow.fWin = XCreateSimpleWindow(dsp,
                                                DefaultRootWindow(dsp),
                                                0, 0,  // x, y
                                                WIDTH, HEIGHT,
                                                0,     // border width
                                                0,     // border value
@@ skipping 157 matching lines @@
                     this->doPaint();
                     break;
                 case kQuitRequest_NextXEventResult:
                     return;
             }
         }
     }
 }
 
 void SkOSWindow::mapWindowAndWait() {
-    SkASSERT(NULL != fUnixWindow.fDisplay);
+    SkASSERT(fUnixWindow.fDisplay);
     Display* dsp = fUnixWindow.fDisplay;
     Window win = fUnixWindow.fWin;
     XMapWindow(dsp, win);
 
     long eventMask = StructureNotifyMask;
     XSelectInput(dsp, win, eventMask);
 
     // Wait until screen is ready.
     XEvent evt;
     do {
         XNextEvent(dsp, &evt);
     } while(evt.type != MapNotify);
 
 }
 
 bool SkOSWindow::attach(SkBackEndTypes, int msaaSampleCount, AttachmentInfo* info) {
     this->initWindow(msaaSampleCount, info);
 
     if (NULL == fUnixWindow.fDisplay) {
         return false;
     }
     if (NULL == fUnixWindow.fGLContext) {
-        SkASSERT(NULL != fVi);
+        SkASSERT(fVi);
 
         fUnixWindow.fGLContext = glXCreateContext(fUnixWindow.fDisplay,
                                                   fVi,
                                                   NULL,
                                                   GL_TRUE);
         if (NULL == fUnixWindow.fGLContext) {
             return false;
         }
     }
     glXMakeCurrent(fUnixWindow.fDisplay,
@@ skipping 11 matching lines @@
 void SkOSWindow::detach() {
     if (NULL == fUnixWindow.fDisplay || NULL == fUnixWindow.fGLContext) {
         return;
     }
     glXMakeCurrent(fUnixWindow.fDisplay, None, NULL);
     glXDestroyContext(fUnixWindow.fDisplay, fUnixWindow.fGLContext);
     fUnixWindow.fGLContext = NULL;
 }
 
 void SkOSWindow::present() {
-    if (NULL != fUnixWindow.fDisplay && NULL != fUnixWindow.fGLContext) {
+    if (fUnixWindow.fDisplay && fUnixWindow.fGLContext) {
         glXSwapBuffers(fUnixWindow.fDisplay, fUnixWindow.fWin);
     }
 }
 
 void SkOSWindow::onSetTitle(const char title[]) {
     if (NULL == fUnixWindow.fDisplay) {
         return;
     }
     XTextProperty textProp;
     textProp.value = (unsigned char*)title;
@@ skipping 19 matching lines @@
     image.bytes_per_line = bitmap.rowBytes() - bitmap.width() * 4;
     image.bits_per_pixel = bitsPerPixel;
     return XInitImage(&image);
 }
 
 void SkOSWindow::doPaint() {
     if (NULL == fUnixWindow.fDisplay) {
         return;
     }
     // If we are drawing with GL, we don't need XPutImage.
-    if (NULL != fUnixWindow.fGLContext) {
+    if (fUnixWindow.fGLContext) {
         return;
     }
     // Draw the bitmap to the screen.
     const SkBitmap& bitmap = getBitmap();
     int width = bitmap.width();
     int height = bitmap.height();
 
     XImage image;
     if (!convertBitmapToXImage(image, bitmap)) {
         return;
@@ skipping 12 matching lines @@
 
 void SkEvent::SignalNonEmptyQueue() {
     // nothing to do, since we spin on our event-queue, polling for XPending
 }
 
 void SkEvent::SignalQueueTimer(SkMSec delay) {
     // just need to record the delay time. We handle waking up for it in
     // MyXNextEventWithDelay()
     gTimerDelay = delay;
 }