src/ports/SkFontMgr_android.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontMgr_android.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontMgr_android.cpp

diff --git a/src/ports/SkFontMgr_android.cpp b/src/ports/SkFontMgr_android.cpp

index e966c84f1ff4054cce84cc66ab2caf0b7a3844ef..bcf544cd43ff184a361535d6691b8bd3f4501bfb 100644

--- a/src/ports/SkFontMgr_android.cpp

+++ b/src/ports/SkFontMgr_android.cpp

@@ -422,7 +422,7 @@ protected:

? SkFontStyle::kItalic_Slant

: SkFontStyle::kUpright_Slant);

- if (NULL != familyName) {

+ if (familyName) {

// On Android, we must return NULL when we can't find the requested

// named typeface so that the system/app can provide their own recovery

// mechanism. On other platforms we'd provide a typeface from the

« no previous file with comments | « src/ports/SkFontHost_mac.cpp ('k') | src/ports/SkFontMgr_fontconfig.cpp » ('j') | no next file with comments »