src/effects/SkTableColorFilter.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkTableColorFilter.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkTableColorFilter.cpp

diff --git a/src/effects/SkTableColorFilter.cpp b/src/effects/SkTableColorFilter.cpp

index 8b391eebf4d1ac6fac29b60e4ebcea63b373795c..3cab10737333ac8c9a3cc4f2108f56bdfaadd18a 100644

--- a/src/effects/SkTableColorFilter.cpp

+++ b/src/effects/SkTableColorFilter.cpp

@@ -438,7 +438,7 @@ GrEffect* SkTable_ColorFilter::asNewEffect(GrContext* context) const {

this->asComponentTable(&bitmap);

// passing NULL because this effect does no tiling or filtering.

GrTexture* texture = GrLockAndRefCachedBitmapTexture(context, bitmap, NULL);

- if (NULL != texture) {

+ if (texture) {

effect = ColorTableEffect::Create(texture, fFlags);

// Unlock immediately, this is not great, but we don't have a way of

« no previous file with comments | « src/effects/SkPictureImageFilter.cpp ('k') | src/effects/gradients/SkGradientShader.cpp » ('j') | no next file with comments »