src/ports/SkOSFile_win.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkOSFile_win.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkOSFile_win.cpp

diff --git a/src/ports/SkOSFile_win.cpp b/src/ports/SkOSFile_win.cpp

index 1430d7f03bf3d1147c2dd4e0be3cd5edfeba4dc5..ded58586b081f65bb42e10304b8664e9548630f9 100644

--- a/src/ports/SkOSFile_win.cpp

+++ b/src/ports/SkOSFile_win.cpp

@@ -66,7 +66,7 @@ public:

SkAutoNullKernelHandle(const HANDLE handle) : fHandle(handle) { }

~SkAutoNullKernelHandle() { CloseHandle(fHandle); }

operator HANDLE() const { return fHandle; }

- bool isValid() const { return NULL != fHandle; }

+ bool isValid() const { return SkToBool(fHandle); }

private:

HANDLE fHandle;

};

« no previous file with comments | « src/ports/SkFontMgr_fontconfig.cpp ('k') | src/ports/SkScalerContext_win_dw.cpp » ('j') | no next file with comments »