src/ports/SkScalerContext_win_dw.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkScalerContext_win_dw.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkScalerContext_win_dw.cpp

diff --git a/src/ports/SkScalerContext_win_dw.cpp b/src/ports/SkScalerContext_win_dw.cpp

index 33ef0d55ec29a3ee7b2efbc911cc98c5441faf6d..e72746a520e42b3093313940df64487de7f68d2b 100644

--- a/src/ports/SkScalerContext_win_dw.cpp

+++ b/src/ports/SkScalerContext_win_dw.cpp

@@ -524,7 +524,7 @@ void SkScalerContext_DW::generateFontMetrics(SkPaint::FontMetrics* metrics) {

metrics->fFlags |= SkPaint::FontMetrics::kUnderlineThinknessIsValid_Flag;

metrics->fFlags |= SkPaint::FontMetrics::kUnderlinePositionIsValid_Flag;

- if (NULL != fTypeface->fDWriteFontFace1.get()) {

+ if (fTypeface->fDWriteFontFace1.get()) {

DWRITE_FONT_METRICS1 dwfm1;

fTypeface->fDWriteFontFace1->GetMetrics(&dwfm1);

metrics->fTop = -fTextSizeRender * SkIntToScalar(dwfm1.glyphBoxTop) / upem;

« no previous file with comments | « src/ports/SkOSFile_win.cpp ('k') | src/ports/SkTypeface_win_dw.cpp » ('j') | no next file with comments »