tools/skdiff_utils.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skdiff_utils.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skdiff_utils.cpp

diff --git a/tools/skdiff_utils.cpp b/tools/skdiff_utils.cpp

index 9157ac6b918c2568cce427ad968002a5d2b05281..14a9fec7e4a126c6bfaf6d7998fbd8a442f3a8f1 100644

--- a/tools/skdiff_utils.cpp

+++ b/tools/skdiff_utils.cpp

@@ -103,7 +103,7 @@ static SkString replace_all(const SkString &input,

const char *first_char = input_cstr;

const char *match_char;

size_t oldSubstringLen = strlen(oldSubstring);

- while (NULL != (match_char = strstr(first_char, oldSubstring))) {

+ while ((match_char = strstr(first_char, oldSubstring))) {

output.append(first_char, (match_char - first_char));

output.append(newSubstring);

first_char = match_char + oldSubstringLen;

« no previous file with comments | « tools/skdiff_main.cpp ('k') | tools/skimage_main.cpp » ('j') | no next file with comments »