tools/skpdiff/skpdiff_util.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpdiff/skpdiff_util.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpdiff/skpdiff_util.cpp

diff --git a/tools/skpdiff/skpdiff_util.cpp b/tools/skpdiff/skpdiff_util.cpp

index 4a92f5e3f76b476b9281f75fed3fcea13df298a7..498f657f9e899c9e479af981369646dd073a0ccf 100644

--- a/tools/skpdiff/skpdiff_util.cpp

+++ b/tools/skpdiff/skpdiff_util.cpp

@@ -174,7 +174,7 @@ bool glob_files(const char globPattern[], SkTArray<SkString>* entries) {

// Note these paths are in sorted order by default according to http://linux.die.net/man/3/glob

// Check under the flag GLOB_NOSORT

char** paths = globBuffer.gl_pathv;

- while(NULL != *paths) {

+ while(*paths) {

entries->push_back(SkString(*paths));

paths++;

}

« no previous file with comments | « tools/skpdiff/skpdiff_main.cpp ('k') | no next file » | no next file with comments »