tools/skdiff_image.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skdiff_image.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skdiff_image.cpp

diff --git a/tools/skdiff_image.cpp b/tools/skdiff_image.cpp

index 172f62b555b17585d829b1f5a54ad4237b949a26..89f73810e70cfeac55d72ab8a6f606c310f4cefa 100644

--- a/tools/skdiff_image.cpp

+++ b/tools/skdiff_image.cpp

@@ -37,11 +37,11 @@ static void create_diff_images (DiffMetricProc dmp,

drp->fComparison.fStatus = DiffResource::kSpecified_Status;

SkAutoDataUnref baseFileBits(read_file(drp->fBase.fFullPath.c_str()));

- if (NULL != baseFileBits) {

+ if (baseFileBits) {

drp->fBase.fStatus = DiffResource::kRead_Status;

}

SkAutoDataUnref comparisonFileBits(read_file(drp->fComparison.fFullPath.c_str()));

- if (NULL != comparisonFileBits) {

+ if (comparisonFileBits) {

drp->fComparison.fStatus = DiffResource::kRead_Status;

}

if (NULL == baseFileBits || NULL == comparisonFileBits) {

« no previous file with comments | « tools/render_pictures_main.cpp ('k') | tools/skdiff_main.cpp » ('j') | no next file with comments »