src/gpu/gl/builders/GrGLShaderBuilder.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLShaderBuilder.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLShaderBuilder.cpp

diff --git a/src/gpu/gl/builders/GrGLShaderBuilder.cpp b/src/gpu/gl/builders/GrGLShaderBuilder.cpp

index 6b3e1d12dd7e3948a365b428520b915df77052c9..b7c7bbf53270268bbd76445caa0cc937894aa7bf 100644

--- a/src/gpu/gl/builders/GrGLShaderBuilder.cpp

+++ b/src/gpu/gl/builders/GrGLShaderBuilder.cpp

@@ -26,7 +26,7 @@ void append_texture_lookup(SkString* out,

uint32_t configComponentMask,

const char* swizzle,

GrSLType varyingType = kVec2f_GrSLType) {

- SkASSERT(NULL != coordName);

+ SkASSERT(coordName);

out->appendf("%s(%s, %s)",

sample_function_name(varyingType, gpu->glslGeneration()),

« no previous file with comments | « src/gpu/gl/builders/GrGLShaderBuilder.h ('k') | src/gpu/gl/debug/GrDebugGL.cpp » ('j') | no next file with comments »