Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 4 months ago
CC:
bajones, aandrey+blink_chromium.org, abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, Rik, Inactive, dglazkov+blink, watchdog-blink-watchlist_google.com, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: move 2D Canvas and WebGL objects to the heap. This adds Oilpan transition types to the WebGL object hierarchy, along with some remaining Canvas 2D objects. Notes: - Oilpan does not allow destructors to access other garbage collected objects and we want all WebGL script accessible objects to be under the control of Oilpan and be garbage collected. To follow and fulfill both, we cannot make the objects that the destructors depend on for fetching out the graphics context (which they use to finalize their platform resources) be garbage collected. For WebGLSharedObjects (and WebGLRenderingContextBase) that means that WebGLContextGroup cannot be on the heap/garbage-collected, and for WebGLContextObjects, the WebGLRenderingContextBase's DrawingBuffer cannot be on the heap either. See details below for how this is done for WebGLContextObject's; the changes to WebGLContextGroup and WebGLSharedObject is along similar lines. - In terms of file footprint of the changes here, the WebGLExtension-derived objects make up a significant portion. Their switch in transition types for their create() constructor method is all standard and repetitive. - The release of platform resources when finalizing WebGL objects requires some extra care with Oilpan. That release is done using a platform graphics context object (blink::WebGraphicsContext3D), which is owned by a DrawingBuffer. As finalization order isn't deterministic with Oilpan, we have to arrange for that DrawingBuffer's context object to remain alive until all objects that need it for platform resource release have been finalized. And we cannot rely on fetching the context object from another WebGL object on the Oilpan heap, as it may or may not have been finalized. To address, the (off heap) DrawingBuffer is shared among all objects that need it for finalization, using an off-heap RefCounted abstraction (WebGLSharedWebGraphicsContext3D). When all objects have been finalized, that shared object will be destructed and its underlying DrawingBuffer (and, indirectly, its blink::WebGraphicsContext3D object) is let go of. As a result, each WebGLContextObject adds a RefPtr<> to this shared DrawingBuffer/WebGraphicsContext3D with Oilpan enabled. R=haraken@chromium.org,ager@chromium.org,junov@chromium.org,bajones@chromium.org,kbr@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178647

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 3

Patch Set 3 : Complete VectorTraits<> specialization for VertexAttribState #

Total comments: 54

Patch Set 4 : Go back to having WebGLContextGroup be RefCounted #

Patch Set 5 : Round of improvements #

Total comments: 25

Patch Set 6 : Rebased + remove some uses of GarbageCollectedFinalized<>. #

Patch Set 7 : Make WebGLObjects keep a blink::WebGraphicsContext3D for finalization. #

Total comments: 26

Patch Set 8 : Introduce a shared DrawingBuffer/WebGraphicsContext3D abstraction #

Patch Set 9 : Move ExtensionTracker back to the heap #

Patch Set 10 : Rebased + Nullable<traceable-value> workaround #

Total comments: 1

Patch Set 11 : Split out WebGLSharedWebGraphicsContext3D into separate file + fix Nullable #

Patch Set 12 : Adjust GC_PLUGIN_IGNORE() bug reference #

Total comments: 18

Patch Set 13 : Add WebGLRenderingContextBase::drawingBuffer() private helper #

Patch Set 14 : Have Nullable<T>::trace() use TraceIfNeeded<>. #

Total comments: 26

Patch Set 15 : Review-induced improvements + rebase #

Total comments: 21

Patch Set 16 : Smaller adjustments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1128 lines, -542 lines) Patch
M Source/bindings/core/v8/Dictionary.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/Dictionary.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/Nullable.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +7 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/TextMetrics.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/html/TextMetrics.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/canvas/ANGLEInstancedArrays.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/ANGLEInstancedArrays.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/ANGLEInstancedArrays.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Canvas2DContextAttributes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/canvas/Canvas2DContextAttributes.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/html/canvas/Canvas2DContextAttributes.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasContextAttributes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasContextAttributes.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasGradient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +8 lines, -5 lines 0 comments Download
M Source/core/html/canvas/CanvasGradient.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasPattern.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasPattern.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 7 chunks +21 lines, -14 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +16 lines, -13 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +18 lines, -12 lines 0 comments Download
M Source/core/html/canvas/EXTBlendMinMax.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTBlendMinMax.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTBlendMinMax.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/EXTFragDepth.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/EXTFragDepth.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTFragDepth.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/EXTShaderTextureLOD.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTShaderTextureLOD.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTShaderTextureLOD.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/EXTTextureFilterAnisotropic.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTTextureFilterAnisotropic.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/EXTTextureFilterAnisotropic.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESElementIndexUint.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESElementIndexUint.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESElementIndexUint.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESStandardDerivatives.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESStandardDerivatives.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESStandardDerivatives.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESTextureFloat.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloat.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloat.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESTextureFloatLinear.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloatLinear.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloatLinear.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloat.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloat.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloat.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloatLinear.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloatLinear.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloatLinear.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Path2D.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +10 lines, -6 lines 0 comments Download
M Source/core/html/canvas/Path2D.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLActiveInfo.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLActiveInfo.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLBuffer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLBuffer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +12 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLBuffer.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureETC1.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureETC1.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureETC1.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTexturePVRTC.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTexturePVRTC.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTexturePVRTC.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLContextAttributes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLContextAttributes.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/html/canvas/WebGLContextAttributes.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLContextGroup.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLContextObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +8 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +20 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDebugRendererInfo.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugRendererInfo.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugRendererInfo.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLDepthTexture.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDepthTexture.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDepthTexture.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLExtension.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +8 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLExtension.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +8 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 8 chunks +55 lines, -16 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLGetInfo.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +20 lines, -19 lines 0 comments Download
M Source/core/html/canvas/WebGLGetInfo.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 10 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/canvas/WebGLLoseContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLLoseContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLLoseContext.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +7 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +20 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLProgram.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +29 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +20 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +23 lines, -21 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +28 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 18 chunks +84 lines, -47 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 62 chunks +225 lines, -120 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLShader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLShader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +10 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLShader.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLShaderPrecisionFormat.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLShaderPrecisionFormat.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLShaderPrecisionFormat.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLSharedObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLSharedObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
A Source/core/html/canvas/WebGLSharedWebGraphicsContext3D.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +48 lines, -0 lines 0 comments Download
A Source/core/html/canvas/WebGLSharedWebGraphicsContext3D.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +54 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +10 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLUniformLocation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLUniformLocation.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLUniformLocation.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +30 lines, -9 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +35 lines, -8 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/heap/Handle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +13 lines, -6 lines 1 comment Download

Messages

Total messages: 70 (0 generated)
sof
Please take a look. As agreed, one CL to handle the changes required to move ...
6 years, 5 months ago (2014-07-01 13:54:11 UTC) #1
sof
Thinking about the dependencies here some more, I'm considering pulling WebGLContextGroup off the heap. That ...
6 years, 5 months ago (2014-07-02 05:52:48 UTC) #2
haraken
Here is a first round of comments! https://codereview.chromium.org/365653002/diff/40001/Source/core/html/canvas/WebGLContextGroup.cpp File Source/core/html/canvas/WebGLContextGroup.cpp (right): https://codereview.chromium.org/365653002/diff/40001/Source/core/html/canvas/WebGLContextGroup.cpp#newcode37 Source/core/html/canvas/WebGLContextGroup.cpp:37: return contextGroup.release(); ...
6 years, 5 months ago (2014-07-02 07:47:39 UTC) #3
sof
On 2014/07/02 07:47:39, haraken wrote: > Here is a first round of comments! > Thanks, ...
6 years, 5 months ago (2014-07-02 07:53:43 UTC) #4
haraken
On 2014/07/02 07:53:43, sof wrote: > On 2014/07/02 07:47:39, haraken wrote: > > Here is ...
6 years, 5 months ago (2014-07-02 08:25:20 UTC) #5
sof
Thanks again for the careful review; followups below. https://codereview.chromium.org/365653002/diff/40001/Source/core/html/canvas/WebGLContextGroup.cpp File Source/core/html/canvas/WebGLContextGroup.cpp (right): https://codereview.chromium.org/365653002/diff/40001/Source/core/html/canvas/WebGLContextGroup.cpp#newcode37 Source/core/html/canvas/WebGLContextGroup.cpp:37: return ...
6 years, 5 months ago (2014-07-02 11:43:54 UTC) #6
haraken
Mostly looks good! Here is the final round of comments. https://codereview.chromium.org/365653002/diff/80001/Source/core/html/TextMetrics.h File Source/core/html/TextMetrics.h (right): https://codereview.chromium.org/365653002/diff/80001/Source/core/html/TextMetrics.h#newcode36 ...
6 years, 5 months ago (2014-07-03 04:40:30 UTC) #7
sof
Looks like we could have hit a brickwall or two here. https://codereview.chromium.org/365653002/diff/80001/Source/core/html/TextMetrics.h File Source/core/html/TextMetrics.h (right): ...
6 years, 5 months ago (2014-07-03 07:25:49 UTC) #8
Ken Russell (switch to Gerrit)
Thanks for working on this. This is a pretty large review and it'll take some ...
6 years, 5 months ago (2014-07-08 19:07:11 UTC) #9
Ken Russell (switch to Gerrit)
Also +junov and +senorblanco for the 2D canvas changes.
6 years, 5 months ago (2014-07-08 19:07:43 UTC) #10
sof
On 2014/07/08 19:07:11, Ken Russell wrote: > Thanks for working on this. This is a ...
6 years, 5 months ago (2014-07-08 19:47:20 UTC) #11
Stephen White
On 2014/07/08 19:07:43, Ken Russell wrote: > Also +junov and +senorblanco for the 2D canvas ...
6 years, 5 months ago (2014-07-08 19:50:21 UTC) #12
Justin Novosad
On 2014/07/08 19:50:21, Stephen White wrote: > On 2014/07/08 19:07:43, Ken Russell wrote: > > ...
6 years, 5 months ago (2014-07-08 20:25:55 UTC) #13
sof
The problem we're faced with here is that platform resource finalization is done with respect ...
6 years, 5 months ago (2014-07-09 11:50:09 UTC) #14
sof
It'd be good if we could get this ready Oilpan-wise before considering asking others to ...
6 years, 5 months ago (2014-07-10 18:01:34 UTC) #15
haraken
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp File Source/core/html/canvas/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp#newcode287 Source/core/html/canvas/WebGLFramebuffer.cpp:287: detach(); Just help me understand: Why was non-oilpan code ...
6 years, 5 months ago (2014-07-11 01:55:02 UTC) #16
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp File Source/core/html/canvas/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp#newcode287 Source/core/html/canvas/WebGLFramebuffer.cpp:287: detach(); On 2014/07/11 01:55:02, haraken wrote: > > Just ...
6 years, 5 months ago (2014-07-11 04:54:10 UTC) #17
haraken
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp File Source/core/html/canvas/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp#newcode287 Source/core/html/canvas/WebGLFramebuffer.cpp:287: detach(); On 2014/07/11 04:54:10, sof wrote: > On 2014/07/11 ...
6 years, 5 months ago (2014-07-11 05:27:54 UTC) #18
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp File Source/core/html/canvas/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp#newcode287 Source/core/html/canvas/WebGLFramebuffer.cpp:287: detach(); On 2014/07/11 05:27:54, haraken wrote: > On 2014/07/11 ...
6 years, 5 months ago (2014-07-11 05:40:09 UTC) #19
haraken
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp File Source/core/html/canvas/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLFramebuffer.cpp#newcode287 Source/core/html/canvas/WebGLFramebuffer.cpp:287: detach(); On 2014/07/11 05:40:09, sof wrote: > On 2014/07/11 ...
6 years, 5 months ago (2014-07-11 05:41:34 UTC) #20
Mads Ager (chromium)
I'm not all the way through yet but here are a couple of comments. I'll ...
6 years, 5 months ago (2014-07-11 06:47:23 UTC) #21
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLObject.cpp File Source/core/html/canvas/WebGLObject.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLObject.cpp#newcode37 Source/core/html/canvas/WebGLObject.cpp:37: , m_context3d(base->webContext()) On 2014/07/11 01:55:02, haraken wrote: > > ...
6 years, 5 months ago (2014-07-11 06:51:35 UTC) #22
haraken
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLObject.cpp File Source/core/html/canvas/WebGLObject.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLObject.cpp#newcode37 Source/core/html/canvas/WebGLObject.cpp:37: , m_context3d(base->webContext()) On 2014/07/11 06:51:35, sof wrote: > On ...
6 years, 5 months ago (2014-07-11 07:01:34 UTC) #23
Mads Ager (chromium)
I few more comments. https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode2385 Source/core/html/canvas/CanvasRenderingContext2D.cpp:2385: RefPtrWillBeMember<Path2D> path2d; RefPtrWillBeRawPtr<Path2D> path2d = ...
6 years, 5 months ago (2014-07-11 09:15:01 UTC) #24
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h File Source/core/html/canvas/WebGLContextGroup.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h#newcode68 Source/core/html/canvas/WebGLContextGroup.h:68: // FIXME: Oilpan: this object is not on the ...
6 years, 5 months ago (2014-07-11 09:42:03 UTC) #25
Mads Ager (chromium)
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h File Source/core/html/canvas/WebGLContextGroup.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h#newcode68 Source/core/html/canvas/WebGLContextGroup.h:68: // FIXME: Oilpan: this object is not on the ...
6 years, 5 months ago (2014-07-11 10:18:53 UTC) #26
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h File Source/core/html/canvas/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode646 Source/core/html/canvas/WebGLRenderingContextBase.h:646: // FIXME: Oilpan: off-heap (vector) collections with OwnPtr<>s On ...
6 years, 5 months ago (2014-07-11 14:00:08 UTC) #27
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h File Source/core/html/canvas/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode646 Source/core/html/canvas/WebGLRenderingContextBase.h:646: // FIXME: Oilpan: off-heap (vector) collections with OwnPtr<>s On ...
6 years, 5 months ago (2014-07-12 07:22:09 UTC) #28
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h File Source/core/html/canvas/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode646 Source/core/html/canvas/WebGLRenderingContextBase.h:646: // FIXME: Oilpan: off-heap (vector) collections with OwnPtr<>s On ...
6 years, 5 months ago (2014-07-13 20:42:18 UTC) #29
sof
This is an unrelated bug, I'd now claim. https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h File Source/core/html/canvas/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode646 Source/core/html/canvas/WebGLRenderingContextBase.h:646: // ...
6 years, 5 months ago (2014-07-14 09:20:16 UTC) #30
Mads Ager (chromium)
On 2014/07/11 14:00:08, sof wrote: > https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h > File Source/core/html/canvas/WebGLRenderingContextBase.h (right): > > https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode646 > ...
6 years, 5 months ago (2014-07-14 09:40:06 UTC) #31
sof
On 2014/07/14 09:40:06, Mads Ager (chromium) wrote: > On 2014/07/11 14:00:08, sof wrote: > > ...
6 years, 5 months ago (2014-07-14 10:03:00 UTC) #32
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h File Source/core/html/canvas/WebGLContextGroup.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h#newcode68 Source/core/html/canvas/WebGLContextGroup.h:68: // FIXME: Oilpan: this object is not on the ...
6 years, 5 months ago (2014-07-14 11:47:53 UTC) #33
sof
https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h File Source/core/html/canvas/WebGLContextGroup.h (right): https://codereview.chromium.org/365653002/diff/120001/Source/core/html/canvas/WebGLContextGroup.h#newcode68 Source/core/html/canvas/WebGLContextGroup.h:68: // FIXME: Oilpan: this object is not on the ...
6 years, 5 months ago (2014-07-14 13:58:45 UTC) #34
sof
haraken: is the use of WebGLSharedWebGraphicsContext3D acceptable to you?
6 years, 5 months ago (2014-07-15 07:51:31 UTC) #35
haraken
> haraken: is the use of WebGLSharedWebGraphicsContext3D acceptable to you? I haven't looked at the ...
6 years, 5 months ago (2014-07-15 09:05:08 UTC) #36
sof
On 2014/07/15 09:05:08, haraken wrote: > > haraken: is the use of WebGLSharedWebGraphicsContext3D acceptable to ...
6 years, 5 months ago (2014-07-15 10:05:13 UTC) #37
sof
On 2014/07/15 10:05:13, sof wrote: > On 2014/07/15 09:05:08, haraken wrote: > > > haraken: ...
6 years, 5 months ago (2014-07-15 14:35:36 UTC) #38
haraken
Mostly looks good! https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLContextObject.cpp File Source/core/html/canvas/WebGLContextObject.cpp (right): https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLContextObject.cpp#newcode44 Source/core/html/canvas/WebGLContextObject.cpp:44: WebGLContextObject::~WebGLContextObject() Just to confirm: This destructor ...
6 years, 5 months ago (2014-07-15 15:04:56 UTC) #39
sof
Thanks; comments below - will follow up with an updated patchset later that tidies. https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLContextObject.cpp ...
6 years, 5 months ago (2014-07-15 16:23:00 UTC) #40
sof
https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLFramebuffer.cpp File Source/core/html/canvas/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLFramebuffer.cpp#newcode288 Source/core/html/canvas/WebGLFramebuffer.cpp:288: deleteObject(0); On 2014/07/15 16:23:00, sof wrote: > On 2014/07/15 ...
6 years, 5 months ago (2014-07-15 21:49:07 UTC) #41
Ken Russell (switch to Gerrit)
On 2014/07/15 14:35:36, sof wrote: > Does WEBGL_shared_resources have a future? First -- I'm very ...
6 years, 5 months ago (2014-07-16 01:40:13 UTC) #42
haraken
From the perspective of oilpan, looks good. I'll take another close look after kbr@'s review. ...
6 years, 5 months ago (2014-07-16 02:08:20 UTC) #43
sof
https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLRenderingContextBase.h File Source/core/html/canvas/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode622 Source/core/html/canvas/WebGLRenderingContextBase.h:622: m_extension = T::create(context); On 2014/07/16 02:08:19, haraken wrote: > ...
6 years, 5 months ago (2014-07-16 05:02:48 UTC) #44
haraken
On 2014/07/16 05:02:48, sof wrote: > https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLRenderingContextBase.h > File Source/core/html/canvas/WebGLRenderingContextBase.h (right): > > https://codereview.chromium.org/365653002/diff/220001/Source/core/html/canvas/WebGLRenderingContextBase.h#newcode622 > ...
6 years, 5 months ago (2014-07-16 05:04:23 UTC) #45
sof
https://codereview.chromium.org/365653002/diff/260001/Source/bindings/core/v8/Nullable.h File Source/bindings/core/v8/Nullable.h (right): https://codereview.chromium.org/365653002/diff/260001/Source/bindings/core/v8/Nullable.h#newcode48 Source/bindings/core/v8/Nullable.h:48: TraceIfNeeded<T>::trace(visitor, &m_value); I rephrased Nullable to use TraceIfNeeded<> instead ...
6 years, 5 months ago (2014-07-16 12:22:35 UTC) #46
sof
On 2014/07/16 01:40:13, Ken Russell wrote: > On 2014/07/15 14:35:36, sof wrote: > > Does ...
6 years, 5 months ago (2014-07-16 13:12:33 UTC) #47
Ken Russell (switch to Gerrit)
On 2014/07/16 13:12:33, sof wrote: > It looks quite daunting I'm afraid, but adding these ...
6 years, 5 months ago (2014-07-17 01:18:30 UTC) #48
bajones
Non-owner LGTM on the WebGL code. A couple of questions/nits. https://codereview.chromium.org/365653002/diff/260001/Source/core/html/canvas/WebGLActiveInfo.h File Source/core/html/canvas/WebGLActiveInfo.h (right): https://codereview.chromium.org/365653002/diff/260001/Source/core/html/canvas/WebGLActiveInfo.h#newcode37 ...
6 years, 5 months ago (2014-07-18 20:31:29 UTC) #49
sof
https://codereview.chromium.org/365653002/diff/260001/Source/core/html/canvas/WebGLActiveInfo.h File Source/core/html/canvas/WebGLActiveInfo.h (right): https://codereview.chromium.org/365653002/diff/260001/Source/core/html/canvas/WebGLActiveInfo.h#newcode37 Source/core/html/canvas/WebGLActiveInfo.h:37: class WebGLActiveInfo FINAL : public RefCountedWillBeGarbageCollectedFinalized<WebGLActiveInfo>, public ScriptWrappable { ...
6 years, 5 months ago (2014-07-18 21:39:30 UTC) #50
Ken Russell (switch to Gerrit)
First, I'm sorry again for taking to long to review this, and thank you for ...
6 years, 5 months ago (2014-07-19 00:27:16 UTC) #51
sof
On 2014/07/14 10:03:00, sof wrote: > On 2014/07/14 09:40:06, Mads Ager (chromium) wrote: > > ...
6 years, 5 months ago (2014-07-19 17:09:56 UTC) #52
sof
https://codereview.chromium.org/365653002/diff/260001/Source/core/html/canvas/WebGLBuffer.cpp File Source/core/html/canvas/WebGLBuffer.cpp (right): https://codereview.chromium.org/365653002/diff/260001/Source/core/html/canvas/WebGLBuffer.cpp#newcode49 Source/core/html/canvas/WebGLBuffer.cpp:49: detachAndDeleteObject(); On 2014/07/19 00:27:15, Ken Russell wrote: > It's ...
6 years, 5 months ago (2014-07-19 19:55:58 UTC) #53
sof
On 2014/07/19 00:27:16, Ken Russell wrote: > First, I'm sorry again for taking to long ...
6 years, 5 months ago (2014-07-19 20:20:05 UTC) #54
sof
https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/WebGLContextGroup.h File Source/core/html/canvas/WebGLContextGroup.h (right): https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/WebGLContextGroup.h#newcode68 Source/core/html/canvas/WebGLContextGroup.h:68: // FIXME: Oilpan: this object is not on the ...
6 years, 5 months ago (2014-07-20 05:04:16 UTC) #55
haraken
Let me take a final look at this CL on Tuesday morning :)
6 years, 5 months ago (2014-07-21 14:10:30 UTC) #56
sof
On 2014/07/21 14:10:30, haraken wrote: > Let me take a final look at this CL ...
6 years, 5 months ago (2014-07-21 14:25:43 UTC) #57
Ken Russell (switch to Gerrit)
On 2014/07/19 20:20:05, sof wrote: > I'll happily pitch in and take care of any ...
6 years, 5 months ago (2014-07-21 17:52:13 UTC) #58
haraken
LGTM with comments. https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode2377 Source/core/html/canvas/CanvasRenderingContext2D.cpp:2377: RefPtrWillBeMember<Path2D> path2d; RefPtrWillBeRawPtr<Path2D> path2d = nullptr; ...
6 years, 5 months ago (2014-07-22 03:46:11 UTC) #59
sof
https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode2377 Source/core/html/canvas/CanvasRenderingContext2D.cpp:2377: RefPtrWillBeMember<Path2D> path2d; On 2014/07/22 03:46:10, haraken wrote: > > ...
6 years, 5 months ago (2014-07-22 06:15:21 UTC) #60
sof
https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/WebGLSharedObject.cpp File Source/core/html/canvas/WebGLSharedObject.cpp (right): https://codereview.chromium.org/365653002/diff/270001/Source/core/html/canvas/WebGLSharedObject.cpp#newcode41 Source/core/html/canvas/WebGLSharedObject.cpp:41: WebGLSharedObject::~WebGLSharedObject() On 2014/07/22 06:15:21, sof wrote: > On 2014/07/22 ...
6 years, 5 months ago (2014-07-22 08:39:57 UTC) #61
haraken
Thanks, LGTM to land :)
6 years, 5 months ago (2014-07-22 08:53:48 UTC) #62
sof
On 2014/07/22 08:53:48, haraken wrote: > Thanks, LGTM to land :) Let's try, thanks everyone.
6 years, 5 months ago (2014-07-22 12:31:46 UTC) #63
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-22 12:32:05 UTC) #64
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/365653002/290001
6 years, 5 months ago (2014-07-22 12:33:12 UTC) #65
commit-bot: I haz the power
Change committed as 178647
6 years, 5 months ago (2014-07-22 13:14:59 UTC) #66
zerny-chromium
https://codereview.chromium.org/365653002/diff/290001/Source/platform/heap/Handle.h File Source/platform/heap/Handle.h (right): https://codereview.chromium.org/365653002/diff/290001/Source/platform/heap/Handle.h#newcode700 Source/platform/heap/Handle.h:700: struct TraceIfNeeded : public TraceIfEnabled<T, WebCore::IsGarbageCollectedType<typename RemoveHeapPointerWrapperTypes<typename WTF::RemovePointer<T>::Type>::Type>::value> { ...
6 years, 4 months ago (2014-08-01 08:05:15 UTC) #67
sof
On 2014/07/21 17:52:13, Ken Russell wrote: > On 2014/07/19 20:20:05, sof wrote: > > I'll ...
6 years, 4 months ago (2014-08-06 17:40:54 UTC) #68
sof
On 2014/07/21 17:52:13, Ken Russell wrote: > On 2014/07/19 20:20:05, sof wrote: > > I'll ...
6 years, 4 months ago (2014-08-06 17:40:54 UTC) #69
Ken Russell (switch to Gerrit)
6 years, 4 months ago (2014-08-09 01:43:03 UTC) #70
Message was sent while issue was closed.
On 2014/08/06 17:40:54, sof wrote:
> On 2014/07/21 17:52:13, Ken Russell wrote:
> > On 2014/07/19 20:20:05, sof wrote:
> > > I'll happily pitch in and take care of any Oilpan adjustments. Along with
> > > removing the hash sets that holds WebGLContextObjects and
> WebGLSharedObjects,
> > > I'm guessing most destructors will turn empty. If so, not much
> Oilpan-specific
> > > code would remain. There could be some follow-on simplifications and
> > adjustments
> > > needed on the Oilpan side with that in place, but shouldn't be a problem.
> > > 
> > > If it lands first, then it is probably easier to restart adding Oilpan
> > > transition types to WebGL.
> > 
> > We'll wait for this CL to land before making any major surgery to WebGL's
> object
> > graph.
> 
> Is there a bug on this improvement? (Just want to make it sure it isn't
> forgotten about.)

Thanks for reminding me. Filed as Issue 402206.

Powered by Google App Engine
This is Rietveld 408576698