Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/core/html/canvas/WebGLProgram.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make WebGLObjects keep a blink::WebGraphicsContext3D for finalization. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 27
28 #include "core/html/canvas/WebGLProgram.h" 28 #include "core/html/canvas/WebGLProgram.h"
29 29
30 #include "core/html/canvas/WebGLContextGroup.h"
30 #include "core/html/canvas/WebGLRenderingContextBase.h" 31 #include "core/html/canvas/WebGLRenderingContextBase.h"
31 32
32 namespace WebCore { 33 namespace WebCore {
33 34
34 PassRefPtr<WebGLProgram> WebGLProgram::create(WebGLRenderingContextBase* ctx) 35 PassRefPtrWillBeRawPtr<WebGLProgram> WebGLProgram::create(WebGLRenderingContextB ase* ctx)
35 { 36 {
36 return adoptRef(new WebGLProgram(ctx)); 37 return adoptRefWillBeNoop(new WebGLProgram(ctx));
37 } 38 }
38 39
39 WebGLProgram::WebGLProgram(WebGLRenderingContextBase* ctx) 40 WebGLProgram::WebGLProgram(WebGLRenderingContextBase* ctx)
40 : WebGLSharedObject(ctx) 41 : WebGLSharedObject(ctx)
41 , m_linkStatus(false) 42 , m_linkStatus(false)
42 , m_linkCount(0) 43 , m_linkCount(0)
43 , m_infoValid(true) 44 , m_infoValid(true)
44 { 45 {
45 ScriptWrappable::init(this); 46 ScriptWrappable::init(this);
46 setObject(ctx->webContext()->createProgram()); 47 setObject(ctx->webContext()->createProgram());
47 } 48 }
48 49
49 WebGLProgram::~WebGLProgram() 50 WebGLProgram::~WebGLProgram()
50 { 51 {
52 #if ENABLE(OILPAN)
Mads Ager (chromium) 2014/07/11 09:15:01 Instead of clearing the pointers here could we #if
53 m_vertexShader = nullptr;
54 m_fragmentShader = nullptr;
55 #endif
56 detach();
51 deleteObject(0); 57 deleteObject(0);
52 } 58 }
53 59
54 void WebGLProgram::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Plat form3DObject obj) 60 void WebGLProgram::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Plat form3DObject obj)
55 { 61 {
56 context3d->deleteProgram(obj); 62 context3d->deleteProgram(obj);
57 if (m_vertexShader) { 63 if (m_vertexShader) {
58 m_vertexShader->onDetached(context3d); 64 m_vertexShader->onDetached(context3d);
59 m_vertexShader = nullptr; 65 m_vertexShader = nullptr;
60 } 66 }
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 } 173 }
168 174
169 void WebGLProgram::cacheInfoIfNeeded() 175 void WebGLProgram::cacheInfoIfNeeded()
170 { 176 {
171 if (m_infoValid) 177 if (m_infoValid)
172 return; 178 return;
173 179
174 if (!object()) 180 if (!object())
175 return; 181 return;
176 182
177 blink::WebGraphicsContext3D* context = getAWebGraphicsContext3D(); 183 if (!contextGroup())
184 return;
185 blink::WebGraphicsContext3D* context = contextGroup()->getAWebGraphicsContex t3D();
178 if (!context) 186 if (!context)
179 return; 187 return;
180 GLint linkStatus = 0; 188 GLint linkStatus = 0;
181 context->getProgramiv(object(), GL_LINK_STATUS, &linkStatus); 189 context->getProgramiv(object(), GL_LINK_STATUS, &linkStatus);
182 m_linkStatus = linkStatus; 190 m_linkStatus = linkStatus;
183 if (m_linkStatus) 191 if (m_linkStatus)
184 cacheActiveAttribLocations(context); 192 cacheActiveAttribLocations(context);
185 m_infoValid = true; 193 m_infoValid = true;
186 } 194 }
187 195
196 void WebGLProgram::trace(Visitor* visitor)
197 {
198 visitor->trace(m_vertexShader);
199 visitor->trace(m_fragmentShader);
200 WebGLSharedObject::trace(visitor);
188 } 201 }
202
203 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698