Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: Source/core/html/canvas/WebGLProgram.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Smaller adjustments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 27
28 #include "core/html/canvas/WebGLProgram.h" 28 #include "core/html/canvas/WebGLProgram.h"
29 29
30 #include "core/html/canvas/WebGLContextGroup.h"
30 #include "core/html/canvas/WebGLRenderingContextBase.h" 31 #include "core/html/canvas/WebGLRenderingContextBase.h"
31 32
32 namespace blink { 33 namespace blink {
33 34
34 PassRefPtr<WebGLProgram> WebGLProgram::create(WebGLRenderingContextBase* ctx) 35 PassRefPtrWillBeRawPtr<WebGLProgram> WebGLProgram::create(WebGLRenderingContextB ase* ctx)
35 { 36 {
36 return adoptRef(new WebGLProgram(ctx)); 37 return adoptRefWillBeNoop(new WebGLProgram(ctx));
37 } 38 }
38 39
39 WebGLProgram::WebGLProgram(WebGLRenderingContextBase* ctx) 40 WebGLProgram::WebGLProgram(WebGLRenderingContextBase* ctx)
40 : WebGLSharedObject(ctx) 41 : WebGLSharedObject(ctx)
41 , m_linkStatus(false) 42 , m_linkStatus(false)
42 , m_linkCount(0) 43 , m_linkCount(0)
43 , m_infoValid(true) 44 , m_infoValid(true)
44 { 45 {
45 ScriptWrappable::init(this); 46 ScriptWrappable::init(this);
46 setObject(ctx->webContext()->createProgram()); 47 setObject(ctx->webContext()->createProgram());
47 } 48 }
48 49
49 WebGLProgram::~WebGLProgram() 50 WebGLProgram::~WebGLProgram()
50 { 51 {
51 deleteObject(0); 52 #if ENABLE(OILPAN)
53 // These heap objects handle detachment on their own. Clear out
54 // the references to prevent deleteObjectImpl() from trying to do
55 // same, as we cannot safely access other heap objects from this
56 // destructor.
57 m_vertexShader = nullptr;
58 m_fragmentShader = nullptr;
59 #endif
60 // Always call detach here to ensure that platform object deletion
61 // happens with Oilpan enabled. It keeps the code regular to do it
62 // with or without Oilpan enabled.
63 //
64 // See comment in WebGLBuffer's destructor for additional
65 // information on why this is done for WebGLSharedObject-derived
66 // objects.
67 detachAndDeleteObject();
52 } 68 }
53 69
54 void WebGLProgram::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Plat form3DObject obj) 70 void WebGLProgram::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Plat form3DObject obj)
55 { 71 {
56 context3d->deleteProgram(obj); 72 context3d->deleteProgram(obj);
57 if (m_vertexShader) { 73 if (m_vertexShader) {
58 m_vertexShader->onDetached(context3d); 74 m_vertexShader->onDetached(context3d);
59 m_vertexShader = nullptr; 75 m_vertexShader = nullptr;
60 } 76 }
61 if (m_fragmentShader) { 77 if (m_fragmentShader) {
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 } 183 }
168 184
169 void WebGLProgram::cacheInfoIfNeeded() 185 void WebGLProgram::cacheInfoIfNeeded()
170 { 186 {
171 if (m_infoValid) 187 if (m_infoValid)
172 return; 188 return;
173 189
174 if (!object()) 190 if (!object())
175 return; 191 return;
176 192
177 blink::WebGraphicsContext3D* context = getAWebGraphicsContext3D(); 193 if (!contextGroup())
194 return;
195 blink::WebGraphicsContext3D* context = contextGroup()->getAWebGraphicsContex t3D();
178 if (!context) 196 if (!context)
179 return; 197 return;
180 GLint linkStatus = 0; 198 GLint linkStatus = 0;
181 context->getProgramiv(object(), GL_LINK_STATUS, &linkStatus); 199 context->getProgramiv(object(), GL_LINK_STATUS, &linkStatus);
182 m_linkStatus = linkStatus; 200 m_linkStatus = linkStatus;
183 if (m_linkStatus) 201 if (m_linkStatus)
184 cacheActiveAttribLocations(context); 202 cacheActiveAttribLocations(context);
185 m_infoValid = true; 203 m_infoValid = true;
186 } 204 }
187 205
206 void WebGLProgram::trace(Visitor* visitor)
207 {
208 visitor->trace(m_vertexShader);
209 visitor->trace(m_fragmentShader);
210 WebGLSharedObject::trace(visitor);
188 } 211 }
212
213 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698